Kasey's feedback

Author: terencechain

beacon-chain/core/signing/signing_root.go

@@ -247,9 +247,9 @@ func ComputeDomain(domainType [DomainByteLength]byte, forkVersion, genesisValida
 
 // This returns the bls domain given by the domain type and fork data root.
 func domain(domainType [DomainByteLength]byte, forkDataRoot []byte) []byte {
-	b := make([]byte, 32)
-	copy(b[0:4], domainType[:4])
-	copy(b[4:], forkDataRoot[:28])
+	b := make([]byte, 0, 32)
+	b = append(b, domainType[:4]...)
+	b = append(b, forkDataRoot[:28]...)
 	return b
 }
 

beacon-chain/sync/validate_aggregate_proof.go

@@ -2,6 +2,7 @@ package sync
 
 import (
 	"context"
+	"encoding/binary"
 	"fmt"
 
 	"github.com/OffchainLabs/prysm/v6/beacon-chain/blockchain"
@@ -265,9 +266,10 @@ func (s *Service) hasSeenAggregatorIndexEpoch(epoch primitives.Epoch, aggregator
 func (s *Service) setAggregatorIndexEpochSeen(epoch primitives.Epoch, aggregatorIndex primitives.ValidatorIndex) {
 	s.seenAggregatedAttestationLock.Lock()
 	defer s.seenAggregatedAttestationLock.Unlock()
+	
 	b := make([]byte, 64)
-	copy(b[0:32], bytesutil.Bytes32(uint64(epoch)))
-	copy(b[32:], bytesutil.Bytes32(uint64(aggregatorIndex)))
+	binary.BigEndian.PutUint64(b[24:], uint64(epoch))
+	binary.BigEndian.PutUint64(b[56:], uint64(aggregatorIndex))
 	s.seenAggregatedAttestationCache.Add(string(b), true)
 }
 

crypto/bls/signature_batch.go

@@ -32,9 +32,13 @@ func NewSet() *SignatureBatch {
 
 // Join merges the provided signature batch to out current one.
 func (s *SignatureBatch) Join(set *SignatureBatch) *SignatureBatch {
+	if cap(s.Signatures)-len(s.Signatures) < len(set.Signatures) &&
+		cap(set.Signatures)-len(set.Signatures) >= len(s.Signatures) {
+		return set.Join(s)
+	}
+
 	total := len(s.Signatures) + len(set.Signatures)
 
-	// Preallocate capacity if needed
 	if cap(s.Signatures) < total {
 		newSigs := make([][]byte, len(s.Signatures), total)
 		copy(newSigs, s.Signatures)
@@ -60,6 +64,7 @@ func (s *SignatureBatch) Join(set *SignatureBatch) *SignatureBatch {
 	s.PublicKeys = append(s.PublicKeys, set.PublicKeys...)
 	s.Messages = append(s.Messages, set.Messages...)
 	s.Descriptions = append(s.Descriptions, set.Descriptions...)
+
 	return s
 }