From cdbc737c04ee05d25909594f2323028023ac6b58 Mon Sep 17 00:00:00 2001 From: Alec Thomas <112640918+a-thomas-22@users.noreply.github.com> Date: Tue, 6 May 2025 14:36:43 -0500 Subject: [PATCH 01/10] feat(nitro): implement GOMAXPROCS logic --- charts/nitro/templates/_helpers.tpl | 117 +++++++++++++++++++++++++++- charts/nitro/values.yaml | 10 +++ 2 files changed, 126 insertions(+), 1 deletion(-) diff --git a/charts/nitro/templates/_helpers.tpl b/charts/nitro/templates/_helpers.tpl index 504505f..fa7f4ba 100644 --- a/charts/nitro/templates/_helpers.tpl +++ b/charts/nitro/templates/_helpers.tpl @@ -120,6 +120,64 @@ nitro args value: {{ printf "%dB" (int (mulf $valueMi ($.Values.env.blockValidatorMemFreeLimit.multiplier | default 0.05) 1048576)) }} {{- end }} {{- end -}} + +{{/* Calculate GOMAXPROCS based on CPU resources */}} +{{- if $.Values.env.nitro.goMaxProcs.enabled }} +{{- $cpuRequest := 0.0 -}} +{{- $cpuLimit := 0.0 -}} +{{- $multiplier := $.Values.env.nitro.goMaxProcs.multiplier | default 2 -}} + +{{/* Get CPU request if set */}} +{{- if and .Values.resources .Values.resources.requests .Values.resources.requests.cpu -}} + {{- $cpuRequestStr := .Values.resources.requests.cpu -}} + {{/* Handle different CPU formats: cores (1), millicores (1000m), or decimal (0.5) */}} + {{- if contains "m" $cpuRequestStr -}} + {{/* Convert millicores to cores (e.g., 500m -> 0.5) */}} + {{- $milliCores := regexFind "^\\d+" $cpuRequestStr | int -}} + {{- $cpuRequest = mulf (divf $milliCores 1000.0) $multiplier -}} + {{- else -}} + {{/* Handle decimal or whole cores */}} + {{- $cpuRequestVal := regexFind "^\\d*\\.?\\d+" $cpuRequestStr | float64 -}} + {{- $cpuRequest = mulf $cpuRequestVal $multiplier -}} + {{- end -}} +{{- end -}} + +{{/* Get CPU limit if set */}} +{{- if and .Values.resources .Values.resources.limits .Values.resources.limits.cpu -}} + {{- $cpuLimitStr := .Values.resources.limits.cpu -}} + {{/* Handle different CPU formats: cores (1), millicores (1000m), or decimal (0.5) */}} + {{- if contains "m" $cpuLimitStr -}} + {{/* Convert millicores to cores (e.g., 500m -> 0.5) */}} + {{- $milliCores := regexFind "^\\d+" $cpuLimitStr | int -}} + {{- $cpuLimit = divf $milliCores 1000.0 -}} + {{- else -}} + {{/* Handle decimal or whole cores */}} + {{- $cpuLimit = regexFind "^\\d*\\.?\\d+" $cpuLimitStr | float64 -}} + {{- end -}} +{{- end -}} + +{{/* Use the higher value between CPU request*multiplier and CPU limit */}} +{{- $maxProcs := 1 -}} +{{- if gt $cpuRequest $cpuLimit -}} + {{- $maxProcs = ceil $cpuRequest -}} +{{- else if gt $cpuLimit 0.0 -}} + {{- $maxProcs = ceil $cpuLimit -}} +{{- else if gt $cpuRequest 0.0 -}} + {{- $maxProcs = ceil $cpuRequest -}} +{{- end -}} + +{{/* Ensure GOMAXPROCS is at least 1 */}} +{{- if lt $maxProcs 1 -}} + {{- $maxProcs = 1 -}} +{{- end -}} + +{{/* Convert to integer */}} +{{- $maxProcsInt := int $maxProcs -}} + +- name: GOMAXPROCS + value: {{ $maxProcsInt | quote }} +{{- end }} +{{- end -}} {{- end -}} {{- define "nitro.splitvalidator.env" -}} @@ -138,6 +196,63 @@ nitro args value: {{ printf "%dMiB" (int (mulf $valueMi ($.Values.env.splitvalidator.goMemLimit.multiplier | default 0.75))) }} {{- end }} {{- end -}} + +{{/* Calculate GOMAXPROCS for splitvalidator based on CPU resources */}} +{{- if $.Values.env.splitvalidator.goMaxProcs.enabled }} +{{- $cpuRequest := 0.0 -}} +{{- $cpuLimit := 0.0 -}} +{{- $multiplier := $.Values.env.splitvalidator.goMaxProcs.multiplier | default 2 -}} + +{{/* Get CPU request if set */}} +{{- if and .Values.validator.splitvalidator.global.resources .Values.validator.splitvalidator.global.resources.requests .Values.validator.splitvalidator.global.resources.requests.cpu -}} + {{- $cpuRequestStr := .Values.validator.splitvalidator.global.resources.requests.cpu -}} + {{/* Handle different CPU formats: cores (1), millicores (1000m), or decimal (0.5) */}} + {{- if contains "m" $cpuRequestStr -}} + {{/* Convert millicores to cores (e.g., 500m -> 0.5) */}} + {{- $milliCores := regexFind "^\\d+" $cpuRequestStr | int -}} + {{- $cpuRequest = mulf (divf $milliCores 1000.0) $multiplier -}} + {{- else -}} + {{/* Handle decimal or whole cores */}} + {{- $cpuRequestVal := regexFind "^\\d*\\.?\\d+" $cpuRequestStr | float64 -}} + {{- $cpuRequest = mulf $cpuRequestVal $multiplier -}} + {{- end -}} +{{- end -}} + +{{/* Get CPU limit if set */}} +{{- if and .Values.validator.splitvalidator.global.resources .Values.validator.splitvalidator.global.resources.limits .Values.validator.splitvalidator.global.resources.limits.cpu -}} + {{- $cpuLimitStr := .Values.validator.splitvalidator.global.resources.limits.cpu -}} + {{/* Handle different CPU formats: cores (1), millicores (1000m), or decimal (0.5) */}} + {{- if contains "m" $cpuLimitStr -}} + {{/* Convert millicores to cores (e.g., 500m -> 0.5) */}} + {{- $milliCores := regexFind "^\\d+" $cpuLimitStr | int -}} + {{- $cpuLimit = divf $milliCores 1000.0 -}} + {{- else -}} + {{/* Handle decimal or whole cores */}} + {{- $cpuLimit = regexFind "^\\d*\\.?\\d+" $cpuLimitStr | float64 -}} + {{- end -}} +{{- end -}} + +{{/* Use the higher value between CPU request*multiplier and CPU limit */}} +{{- $maxProcs := 1 -}} +{{- if gt $cpuRequest $cpuLimit -}} + {{- $maxProcs = ceil $cpuRequest -}} +{{- else if gt $cpuLimit 0.0 -}} + {{- $maxProcs = ceil $cpuLimit -}} +{{- else if gt $cpuRequest 0.0 -}} + {{- $maxProcs = ceil $cpuRequest -}} +{{- end -}} + +{{/* Ensure GOMAXPROCS is at least 1 */}} +{{- if lt $maxProcs 1 -}} + {{- $maxProcs = 1 -}} +{{- end -}} + +{{/* Convert to integer */}} +{{- $maxProcsInt := int $maxProcs -}} + +- name: GOMAXPROCS + value: {{ $maxProcsInt | quote }} +{{- end }} {{- end -}} {{/* @@ -194,4 +309,4 @@ Currently primarily used for stateless validator configuration {{- end -}} {{- define "nitro.lifecycle" -}} -{{- end -}} \ No newline at end of file +{{- end -}} diff --git a/charts/nitro/values.yaml b/charts/nitro/values.yaml index 5cc915e..b18ee4a 100644 --- a/charts/nitro/values.yaml +++ b/charts/nitro/values.yaml @@ -51,8 +51,12 @@ updateStrategy: ## @param env.splitvalidator.goMemLimit.enabled Enable setting the garbage cleanup limit in Go for the split validator ## @param env.splitvalidator.goMemLimit.multiplier The multiplier of available memory to use for the split validator +## @param env.splitvalidator.goMaxProcs.enabled Enable setting GOMAXPROCS for the split validator +## @param env.splitvalidator.goMaxProcs.multiplier The multiplier to use for CPU request (default 2) ## @param env.nitro.goMemLimit.enabled Enable setting the garbage cleanup limit in Go for nitro ## @param env.nitro.goMemLimit.multiplier The multiplier of available memory to use for nitro +## @param env.nitro.goMaxProcs.enabled Enable setting GOMAXPROCS for nitro +## @param env.nitro.goMaxProcs.multiplier The multiplier to use for CPU request (default 2) ## @param env.resourceMgmtMemFreeLimit.enabled Enable nitro resource management ## @param env.resourceMgmtMemFreeLimit.multiplier The multiplier of available memory to use ## @param env.blockValidatorMemFreeLimit.enabled Enable block validator memory management @@ -62,10 +66,16 @@ env: goMemLimit: enabled: true multiplier: 0.75 + goMaxProcs: + enabled: true + multiplier: 2 nitro: goMemLimit: enabled: true multiplier: 0.9 + goMaxProcs: + enabled: true + multiplier: 2 resourceMgmtMemFreeLimit: enabled: false multiplier: 0.05 From 81be490c194d2cc192f1eb8d596cdc34a42df890 Mon Sep 17 00:00:00 2001 From: a-thomas-22 <112640918+a-thomas-22@users.noreply.github.com> Date: Tue, 6 May 2025 19:37:34 +0000 Subject: [PATCH 02/10] Update README for modified charts --- charts/nitro/README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/charts/nitro/README.md b/charts/nitro/README.md index 5228b3e..4102796 100644 --- a/charts/nitro/README.md +++ b/charts/nitro/README.md @@ -94,8 +94,12 @@ helm install xai offchainlabs/nitro -f values.yaml | `updateStrategy.type` | Update strategy type | `RollingUpdate` | | `env.splitvalidator.goMemLimit.enabled` | Enable setting the garbage cleanup limit in Go for the split validator | `true` | | `env.splitvalidator.goMemLimit.multiplier` | The multiplier of available memory to use for the split validator | `0.75` | +| `env.splitvalidator.goMaxProcs.enabled` | Enable setting GOMAXPROCS for the split validator | `true` | +| `env.splitvalidator.goMaxProcs.multiplier` | The multiplier to use for CPU request (default 2) | `2` | | `env.nitro.goMemLimit.enabled` | Enable setting the garbage cleanup limit in Go for nitro | `true` | | `env.nitro.goMemLimit.multiplier` | The multiplier of available memory to use for nitro | `0.9` | +| `env.nitro.goMaxProcs.enabled` | Enable setting GOMAXPROCS for nitro | `true` | +| `env.nitro.goMaxProcs.multiplier` | The multiplier to use for CPU request (default 2) | `2` | | `env.resourceMgmtMemFreeLimit.enabled` | Enable nitro resource management | `false` | | `env.resourceMgmtMemFreeLimit.multiplier` | The multiplier of available memory to use | `0.05` | | `env.blockValidatorMemFreeLimit.enabled` | Enable block validator memory management | `false` | From 9cc1ce1a8d42c8b0f90e7c57a63867bcc17cd457 Mon Sep 17 00:00:00 2001 From: Alec Thomas <112640918+a-thomas-22@users.noreply.github.com> Date: Tue, 6 May 2025 14:37:43 -0500 Subject: [PATCH 03/10] Update Chart.yaml --- charts/nitro/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/nitro/Chart.yaml b/charts/nitro/Chart.yaml index 6d00a95..0bdf3b5 100644 --- a/charts/nitro/Chart.yaml +++ b/charts/nitro/Chart.yaml @@ -7,6 +7,6 @@ maintainers: type: application -version: 0.7.0 +version: 0.7.2 appVersion: "v3.6.0-fc07dd2" From 4f96b06930390ee8a3f3c1d83534163df9d2da04 Mon Sep 17 00:00:00 2001 From: Alec Thomas <112640918+a-thomas-22@users.noreply.github.com> Date: Tue, 6 May 2025 17:00:56 -0500 Subject: [PATCH 04/10] Update _helpers.tpl --- charts/nitro/templates/_helpers.tpl | 130 ++++++++++++++++------------ 1 file changed, 73 insertions(+), 57 deletions(-) diff --git a/charts/nitro/templates/_helpers.tpl b/charts/nitro/templates/_helpers.tpl index fa7f4ba..eae5a7a 100644 --- a/charts/nitro/templates/_helpers.tpl +++ b/charts/nitro/templates/_helpers.tpl @@ -97,7 +97,9 @@ nitro args {{- if and (get .Values.env.nitro.goMemLimit "enabled" | default false) (not $envPrefix) -}} {{- fail "configmap.data.conf.env-prefix must be set when goMemLimit is enabled" -}} {{- end -}} -{{- if and .Values.resources .Values.resources.limits .Values.resources.limits.memory -}} + +{{/* Memory-based environment variables */}} +{{- if and .Values.resources .Values.resources.limits .Values.resources.limits.memory .Values.env.nitro.goMemLimit.enabled -}} {{- $memory := .Values.resources.limits.memory -}} {{- $value := regexFind "^\\d*\\.?\\d+" $memory | float64 -}} {{- $unit := regexFind "[A-Za-z]+" $memory -}} @@ -107,29 +109,47 @@ nitro args {{- else if eq $unit "Mi" -}} {{- $valueMi = $value -}} {{- end }} -{{- if $.Values.env.nitro.goMemLimit.enabled }} - name: GOMEMLIMIT - value: {{ printf "%dMiB" (int (mulf $valueMi ($.Values.env.nitro.goMemLimit.multiplier | default 0.9))) }} + value: {{ printf "%dMiB" (int (mulf $valueMi ($.Values.env.nitro.goMemLimit.multiplier | default 0.9))) | quote }} +{{- end }} + +{{- if and .Values.resources .Values.resources.limits .Values.resources.limits.memory .Values.env.resourceMgmtMemFreeLimit.enabled -}} +{{- $memory := .Values.resources.limits.memory -}} +{{- $value := regexFind "^\\d*\\.?\\d+" $memory | float64 -}} +{{- $unit := regexFind "[A-Za-z]+" $memory -}} +{{- $valueMi := 0.0 -}} +{{- if eq $unit "Gi" -}} + {{- $valueMi = mulf $value 1024 -}} +{{- else if eq $unit "Mi" -}} + {{- $valueMi = $value -}} {{- end }} -{{- if $.Values.env.resourceMgmtMemFreeLimit.enabled }} - name: {{ $envPrefix }}_NODE_RESOURCE__MGMT_MEM__FREE__LIMIT - value: {{ printf "%dB" (int (mulf $valueMi ($.Values.env.resourceMgmtMemFreeLimit.multiplier | default 0.05) 1048576)) }} + value: {{ printf "%dB" (int (mulf $valueMi ($.Values.env.resourceMgmtMemFreeLimit.multiplier | default 0.05) 1048576)) | quote }} +{{- end }} + +{{- if and .Values.resources .Values.resources.limits .Values.resources.limits.memory .Values.env.blockValidatorMemFreeLimit.enabled -}} +{{- $memory := .Values.resources.limits.memory -}} +{{- $value := regexFind "^\\d*\\.?\\d+" $memory | float64 -}} +{{- $unit := regexFind "[A-Za-z]+" $memory -}} +{{- $valueMi := 0.0 -}} +{{- if eq $unit "Gi" -}} + {{- $valueMi = mulf $value 1024 -}} +{{- else if eq $unit "Mi" -}} + {{- $valueMi = $value -}} {{- end }} -{{- if $.Values.env.blockValidatorMemFreeLimit.enabled }} - name: {{ $envPrefix }}_NODE_BLOCK__VALIDATOR_MEMORY__FREE__LIMIT - value: {{ printf "%dB" (int (mulf $valueMi ($.Values.env.blockValidatorMemFreeLimit.multiplier | default 0.05) 1048576)) }} + value: {{ printf "%dB" (int (mulf $valueMi ($.Values.env.blockValidatorMemFreeLimit.multiplier | default 0.05) 1048576)) | quote }} {{- end }} -{{- end -}} -{{/* Calculate GOMAXPROCS based on CPU resources */}} -{{- if $.Values.env.nitro.goMaxProcs.enabled }} +{{/* CPU-based environment variables */}} +{{- if .Values.env.nitro.goMaxProcs.enabled -}} {{- $cpuRequest := 0.0 -}} {{- $cpuLimit := 0.0 -}} {{- $multiplier := $.Values.env.nitro.goMaxProcs.multiplier | default 2 -}} {{/* Get CPU request if set */}} {{- if and .Values.resources .Values.resources.requests .Values.resources.requests.cpu -}} - {{- $cpuRequestStr := .Values.resources.requests.cpu -}} + {{- $cpuRequestStr := toString .Values.resources.requests.cpu -}} {{/* Handle different CPU formats: cores (1), millicores (1000m), or decimal (0.5) */}} {{- if contains "m" $cpuRequestStr -}} {{/* Convert millicores to cores (e.g., 500m -> 0.5) */}} @@ -144,7 +164,7 @@ nitro args {{/* Get CPU limit if set */}} {{- if and .Values.resources .Values.resources.limits .Values.resources.limits.cpu -}} - {{- $cpuLimitStr := .Values.resources.limits.cpu -}} + {{- $cpuLimitStr := toString .Values.resources.limits.cpu -}} {{/* Handle different CPU formats: cores (1), millicores (1000m), or decimal (0.5) */}} {{- if contains "m" $cpuLimitStr -}} {{/* Convert millicores to cores (e.g., 500m -> 0.5) */}} @@ -156,32 +176,31 @@ nitro args {{- end -}} {{- end -}} -{{/* Use the higher value between CPU request*multiplier and CPU limit */}} -{{- $maxProcs := 1 -}} -{{- if gt $cpuRequest $cpuLimit -}} - {{- $maxProcs = ceil $cpuRequest -}} -{{- else if gt $cpuLimit 0.0 -}} - {{- $maxProcs = ceil $cpuLimit -}} -{{- else if gt $cpuRequest 0.0 -}} - {{- $maxProcs = ceil $cpuRequest -}} -{{- end -}} - -{{/* Ensure GOMAXPROCS is at least 1 */}} -{{- if lt $maxProcs 1 -}} - {{- $maxProcs = 1 -}} -{{- end -}} - -{{/* Convert to integer */}} -{{- $maxProcsInt := int $maxProcs -}} +{{/* Only set GOMAXPROCS if CPU requests or limits are defined */}} +{{- if or (gt $cpuRequest 0.0) (gt $cpuLimit 0.0) -}} + {{/* Use the higher value between CPU request*multiplier and CPU limit */}} + {{- $maxProcs := 0 -}} + {{- if gt $cpuRequest $cpuLimit -}} + {{- $maxProcs = ceil $cpuRequest | int -}} + {{- else if gt $cpuLimit 0.0 -}} + {{- $maxProcs = ceil $cpuLimit | int -}} + {{- else if gt $cpuRequest 0.0 -}} + {{- $maxProcs = ceil $cpuRequest | int -}} + {{- end -}} + {{/* Ensure GOMAXPROCS is at least 1 */}} + {{- if eq $maxProcs 0 -}} + {{- $maxProcs = 1 -}} + {{- end }} - name: GOMAXPROCS - value: {{ $maxProcsInt | quote }} + value: {{ $maxProcs | quote }} +{{- end }} {{- end }} -{{- end -}} {{- end -}} {{- define "nitro.splitvalidator.env" -}} -{{- if and .Values.validator .Values.validator.splitvalidator .Values.validator.splitvalidator.global .Values.validator.splitvalidator.global.resources .Values.validator.splitvalidator.global.resources.limits .Values.validator.splitvalidator.global.resources.limits.memory -}} +{{/* Memory-based environment variables */}} +{{- if and .Values.validator .Values.validator.splitvalidator .Values.validator.splitvalidator.global .Values.validator.splitvalidator.global.resources .Values.validator.splitvalidator.global.resources.limits .Values.validator.splitvalidator.global.resources.limits.memory .Values.env.splitvalidator.goMemLimit.enabled -}} {{- $memory := .Values.validator.splitvalidator.global.resources.limits.memory -}} {{- $value := regexFind "^\\d*\\.?\\d+" $memory | float64 -}} {{- $unit := regexFind "[A-Za-z]+" $memory -}} @@ -191,21 +210,19 @@ nitro args {{- else if eq $unit "Mi" -}} {{- $valueMi = $value -}} {{- end }} -{{- if $.Values.env.splitvalidator.goMemLimit.enabled }} - name: GOMEMLIMIT - value: {{ printf "%dMiB" (int (mulf $valueMi ($.Values.env.splitvalidator.goMemLimit.multiplier | default 0.75))) }} + value: {{ printf "%dMiB" (int (mulf $valueMi ($.Values.env.splitvalidator.goMemLimit.multiplier | default 0.75))) | quote }} {{- end }} -{{- end -}} -{{/* Calculate GOMAXPROCS for splitvalidator based on CPU resources */}} -{{- if $.Values.env.splitvalidator.goMaxProcs.enabled }} +{{/* CPU-based environment variables */}} +{{- if .Values.env.splitvalidator.goMaxProcs.enabled -}} {{- $cpuRequest := 0.0 -}} {{- $cpuLimit := 0.0 -}} {{- $multiplier := $.Values.env.splitvalidator.goMaxProcs.multiplier | default 2 -}} {{/* Get CPU request if set */}} {{- if and .Values.validator.splitvalidator.global.resources .Values.validator.splitvalidator.global.resources.requests .Values.validator.splitvalidator.global.resources.requests.cpu -}} - {{- $cpuRequestStr := .Values.validator.splitvalidator.global.resources.requests.cpu -}} + {{- $cpuRequestStr := toString .Values.validator.splitvalidator.global.resources.requests.cpu -}} {{/* Handle different CPU formats: cores (1), millicores (1000m), or decimal (0.5) */}} {{- if contains "m" $cpuRequestStr -}} {{/* Convert millicores to cores (e.g., 500m -> 0.5) */}} @@ -220,7 +237,7 @@ nitro args {{/* Get CPU limit if set */}} {{- if and .Values.validator.splitvalidator.global.resources .Values.validator.splitvalidator.global.resources.limits .Values.validator.splitvalidator.global.resources.limits.cpu -}} - {{- $cpuLimitStr := .Values.validator.splitvalidator.global.resources.limits.cpu -}} + {{- $cpuLimitStr := toString .Values.validator.splitvalidator.global.resources.limits.cpu -}} {{/* Handle different CPU formats: cores (1), millicores (1000m), or decimal (0.5) */}} {{- if contains "m" $cpuLimitStr -}} {{/* Convert millicores to cores (e.g., 500m -> 0.5) */}} @@ -232,26 +249,25 @@ nitro args {{- end -}} {{- end -}} -{{/* Use the higher value between CPU request*multiplier and CPU limit */}} -{{- $maxProcs := 1 -}} -{{- if gt $cpuRequest $cpuLimit -}} - {{- $maxProcs = ceil $cpuRequest -}} -{{- else if gt $cpuLimit 0.0 -}} - {{- $maxProcs = ceil $cpuLimit -}} -{{- else if gt $cpuRequest 0.0 -}} - {{- $maxProcs = ceil $cpuRequest -}} -{{- end -}} - -{{/* Ensure GOMAXPROCS is at least 1 */}} -{{- if lt $maxProcs 1 -}} - {{- $maxProcs = 1 -}} -{{- end -}} - -{{/* Convert to integer */}} -{{- $maxProcsInt := int $maxProcs -}} +{{/* Only set GOMAXPROCS if CPU requests or limits are defined */}} +{{- if or (gt $cpuRequest 0.0) (gt $cpuLimit 0.0) -}} + {{/* Use the higher value between CPU request*multiplier and CPU limit */}} + {{- $maxProcs := 0 -}} + {{- if gt $cpuRequest $cpuLimit -}} + {{- $maxProcs = ceil $cpuRequest | int -}} + {{- else if gt $cpuLimit 0.0 -}} + {{- $maxProcs = ceil $cpuLimit | int -}} + {{- else if gt $cpuRequest 0.0 -}} + {{- $maxProcs = ceil $cpuRequest | int -}} + {{- end -}} + {{/* Ensure GOMAXPROCS is at least 1 */}} + {{- if eq $maxProcs 0 -}} + {{- $maxProcs = 1 -}} + {{- end }} - name: GOMAXPROCS - value: {{ $maxProcsInt | quote }} + value: {{ $maxProcs | quote }} +{{- end }} {{- end }} {{- end -}} From 3946b32786e2de682e31e82ce8f2d749f5a5f9f3 Mon Sep 17 00:00:00 2001 From: Alec Thomas <112640918+a-thomas-22@users.noreply.github.com> Date: Tue, 6 May 2025 17:02:00 -0500 Subject: [PATCH 05/10] Update values.yaml --- charts/nitro/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/nitro/values.yaml b/charts/nitro/values.yaml index e8a7f66..6d703a0 100644 --- a/charts/nitro/values.yaml +++ b/charts/nitro/values.yaml @@ -74,7 +74,7 @@ env: enabled: true multiplier: 0.9 goMaxProcs: - enabled: true + enabled: false multiplier: 2 resourceMgmtMemFreeLimit: enabled: false From 5a6b6d986d6ba596669401bde06db3e767bdb04d Mon Sep 17 00:00:00 2001 From: a-thomas-22 <112640918+a-thomas-22@users.noreply.github.com> Date: Tue, 6 May 2025 22:02:40 +0000 Subject: [PATCH 06/10] Update README for modified charts --- charts/nitro/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/nitro/README.md b/charts/nitro/README.md index e46e340..d702477 100644 --- a/charts/nitro/README.md +++ b/charts/nitro/README.md @@ -98,7 +98,7 @@ helm install xai offchainlabs/nitro -f values.yaml | `env.splitvalidator.goMaxProcs.multiplier` | The multiplier to use for CPU request (default 2) | `2` | | `env.nitro.goMemLimit.enabled` | Enable setting the garbage cleanup limit in Go for nitro | `true` | | `env.nitro.goMemLimit.multiplier` | The multiplier of available memory to use for nitro | `0.9` | -| `env.nitro.goMaxProcs.enabled` | Enable setting GOMAXPROCS for nitro | `true` | +| `env.nitro.goMaxProcs.enabled` | Enable setting GOMAXPROCS for nitro | `false` | | `env.nitro.goMaxProcs.multiplier` | The multiplier to use for CPU request (default 2) | `2` | | `env.resourceMgmtMemFreeLimit.enabled` | Enable nitro resource management | `false` | | `env.resourceMgmtMemFreeLimit.multiplier` | The multiplier of available memory to use | `0.05` | From fb8d0a707683263e897a6a69fad48e4be75644d9 Mon Sep 17 00:00:00 2001 From: Alec Thomas <112640918+a-thomas-22@users.noreply.github.com> Date: Tue, 6 May 2025 17:02:59 -0500 Subject: [PATCH 07/10] Trigger CI From f9a523ea49ec344c120c35cdf496e069369e1a4c Mon Sep 17 00:00:00 2001 From: a-thomas-22 <112640918+a-thomas-22@users.noreply.github.com> Date: Thu, 15 May 2025 05:13:41 +0000 Subject: [PATCH 08/10] Update README for modified charts --- charts/nitro/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/nitro/README.md b/charts/nitro/README.md index 7ec4321..f88b2a3 100644 --- a/charts/nitro/README.md +++ b/charts/nitro/README.md @@ -74,7 +74,7 @@ helm install xai offchainlabs/nitro -f values.yaml ### Nitro Deployment Options | Name | Description | Value | -|------------------------------------------------------------|---------------------------------------------------------------------------------|---------------------------------------------------------------------| +| ---------------------------------------------------------- | ------------------------------------------------------------------------------- | ------------------------------------------------------------------- | | `lifecycle` | Lifecycle hooks configuration | `{}` | | `extraEnv` | Additional environment variables for the container | `{}` | | `replicaCount` | Number of replicas to deploy | `1` | @@ -184,7 +184,7 @@ helm install xai offchainlabs/nitro -f values.yaml ### Stateless Validator | Name | Description | Value | -|-------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------|-------------------------------| +| ----------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------- | ----------------------------- | | `validator.enabled` | Enable the stateless validator | `false` | | `validator.splitvalidator.deployments` | List of deployments for the split validator. Each deploymeny can have its own image, config, etc. | `[]` | | `validator.splitvalidator.global.replicaCount` | Number of replicas for the split validator | `1` | From 6d4fd70328a046c9bfc65c9c6f26b218f8e33832 Mon Sep 17 00:00:00 2001 From: Alec Thomas <112640918+a-thomas-22@users.noreply.github.com> Date: Thu, 15 May 2025 00:16:21 -0500 Subject: [PATCH 09/10] Trigger CI From 312d35cf4a789124c42099f59a46811ca1d7684d Mon Sep 17 00:00:00 2001 From: Alec Thomas <112640918+a-thomas-22@users.noreply.github.com> Date: Thu, 15 May 2025 00:17:25 -0500 Subject: [PATCH 10/10] Update Chart.yaml --- charts/nitro/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/nitro/Chart.yaml b/charts/nitro/Chart.yaml index dfec473..29e2ba1 100644 --- a/charts/nitro/Chart.yaml +++ b/charts/nitro/Chart.yaml @@ -7,6 +7,6 @@ maintainers: type: application -version: 0.7.2 +version: 0.7.3 appVersion: "v3.6.2-5b41a2d"