Merge pull request #3 from Oefenweb/consistency-changes

Consistency changes

Author: tersmitten

.ansible-lint

@@ -1,4 +1,5 @@
 ---
 warn_list:
   - role-name
+  - name[play]
   - name[casing]

.github/workflows/ci.yml

@@ -23,7 +23,9 @@ jobs:
           python-version: '3.x'
 
       - name: Install test dependencies
-        run: pip install ansible-lint[community,yamllint]
+        run: |
+          pip install ansible-lint
+          ansible-galaxy install -r requirements.yml
 
       - name: Lint code
         run: |
@@ -43,11 +45,8 @@ jobs:
       matrix:
         include:
           - distro: debian8
-            ansible-version: '<2.10'
           - distro: debian9
           - distro: debian10
-          - distro: ubuntu1604
-            ansible-version: '>=2.9, <2.10'
           - distro: ubuntu1604
             ansible-version: '>=2.10, <2.11'
           - distro: ubuntu1604
@@ -66,7 +65,7 @@ jobs:
           python-version: '3.x'
 
       - name: Install test dependencies
-        run: pip install 'ansible${{ matrix.ansible-version }}' molecule[docker] docker
+        run: pip install 'ansible${{ matrix.ansible-version }}' molecule-plugins[docker] docker
 
       - name: Run Molecule tests
         run: |

handlers/main.yml

@@ -1,12 +1,12 @@
 # handlers file
 ---
-- name: apply netplan config
-  command: >
+- name: apply netplan config  # noqa no-changed-when
+  ansible.builtin.command: >
     netplan apply
   listen: netplan apply config
 
-- name: generate netplan config
-  command: >
+- name: generate netplan config  # noqa no-changed-when
+  ansible.builtin.command: >
     netplan generate
   listen: netplan generate config
   notify: netplan apply config

tasks/configure.yml

@@ -1,28 +1,27 @@
 # tasks file
 ---
-- block:
-
+- name: configure
+  when: netplan_conf_purge | bool
+  tags:
+    - netplan-configure-purge
+  block:
     - name: configure | find existing
-      find:
+      ansible.builtin.find:
         paths: "{{ netplan_conf_path }}"
         patterns: '*.yaml,*.yml'
       register: _netplan_existing_files
 
     - name: configure | remove existing
-      file:
+      ansible.builtin.file:
         path: "{{ item['path'] }}"
         state: absent
       with_items: "{{ _netplan_existing_files['files'] }}"
       when:
         - item['path'] != netplan_conf_path + '/' + netplan_conf_file
       notify: netplan generate config
 
-  when: netplan_conf_purge | bool
-  tags:
-    - netplan-configure-purge
-
 - name: configure | update
-  template:
+  ansible.builtin.template:
     src: etc/netplan/config.yaml.j2
     dest: "{{ netplan_conf_path }}/{{ netplan_conf_file }}"
     mode: 0644

tasks/install.yml

@@ -1,7 +1,7 @@
 # tasks file
 ---
 - name: install | dependencies
-  apt:
+  ansible.builtin.apt:
     name: "{{ netplan_dependencies }}"
     state: "{{ apt_install_state | default('latest') }}"
     update_cache: true
@@ -10,7 +10,7 @@
     - netplan-install-dependencies
 
 - name: install | additional
-  apt:
+  ansible.builtin.apt:
     name: "{{ netplan_install }}"
     state: "{{ apt_install_state | default('latest') }}"
   tags:

tasks/main.yml

@@ -1,12 +1,14 @@
 # tasks file
 ---
-- import_tasks: install.yml
+- name: install
+  ansible.builtin.import_tasks: install.yml
   tags:
     - configuration
     - netplan
     - netplan-install
 
-- import_tasks: configure.yml
+- name: configure
+  ansible.builtin.import_tasks: configure.yml
   tags:
     - configuration
     - netplan