Skip to content

Commit 38e6722

Browse files
committed
Fix a bunch of the Command Injection test cases to work properly on Unix.
1 parent 27784a7 commit 38e6722

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+48
-48
lines changed

src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00171.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr
6868
a1 = "sh";
6969
a2 = "-c";
7070
cmd = org.owasp.benchmark.helpers.Utils.getOSCommandString("ls");
71-
args = new String[]{a1, a2,cmd + bar};
71+
args = new String[]{a1, a2, cmd, bar};
7272
}
7373

7474
String[] argsEnv = { "foo=bar" };

src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00303.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr
6969
a1 = "sh";
7070
a2 = "-c";
7171
cmd = org.owasp.benchmark.helpers.Utils.getOSCommandString("ping -c1");
72-
args = new String[]{a1, a2,cmd + bar};
72+
args = new String[]{a1, a2, cmd, bar};
7373
}
7474

7575
Runtime r = Runtime.getRuntime();

src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00304.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr
7575
a1 = "sh";
7676
a2 = "-c";
7777
cmd = org.owasp.benchmark.helpers.Utils.getOSCommandString("ls");
78-
args = new String[]{a1, a2,cmd + bar};
78+
args = new String[]{a1, a2, cmd, bar};
7979
}
8080

8181
String[] argsEnv = { "foo=bar" };

src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00305.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr
7979
a1 = "sh";
8080
a2 = "-c";
8181
cmd = org.owasp.benchmark.helpers.Utils.getOSCommandString("ls");
82-
args = new String[]{a1, a2,cmd + bar};
82+
args = new String[]{a1, a2, cmd, bar};
8383
}
8484

8585
String[] argsEnv = { "foo=bar" };

src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00406.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr
6868
a1 = "sh";
6969
a2 = "-c";
7070
cmd = org.owasp.benchmark.helpers.Utils.getOSCommandString("ping -c1");
71-
args = new String[]{a1, a2,cmd + bar};
71+
args = new String[]{a1, a2, cmd, bar};
7272
}
7373

7474
Runtime r = Runtime.getRuntime();

src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00407.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr
7272
a1 = "sh";
7373
a2 = "-c";
7474
cmd = org.owasp.benchmark.helpers.Utils.getOSCommandString("ls");
75-
args = new String[]{a1, a2,cmd + bar};
75+
args = new String[]{a1, a2, cmd, bar};
7676
}
7777

7878
String[] argsEnv = { "foo=bar" };

src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00408.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr
6868
a1 = "sh";
6969
a2 = "-c";
7070
cmd = org.owasp.benchmark.helpers.Utils.getOSCommandString("ls");
71-
args = new String[]{a1, a2,cmd + bar};
71+
args = new String[]{a1, a2, cmd, bar};
7272
}
7373

7474
String[] argsEnv = { "foo=bar" };

src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00409.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr
8181
a1 = "sh";
8282
a2 = "-c";
8383
cmd = org.owasp.benchmark.helpers.Utils.getOSCommandString("ls");
84-
args = new String[]{a1, a2,cmd + bar};
84+
args = new String[]{a1, a2, cmd, bar};
8585
}
8686

8787
String[] argsEnv = { "foo=bar" };

src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00494.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr
7777
a1 = "sh";
7878
a2 = "-c";
7979
cmd = org.owasp.benchmark.helpers.Utils.getOSCommandString("ping -c1");
80-
args = new String[]{a1, a2,cmd + bar};
80+
args = new String[]{a1, a2, cmd, bar};
8181
}
8282

8383
Runtime r = Runtime.getRuntime();

src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00568.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response) thr
7777
a1 = "sh";
7878
a2 = "-c";
7979
cmd = org.owasp.benchmark.helpers.Utils.getOSCommandString("ls");
80-
args = new String[]{a1, a2,cmd + bar};
80+
args = new String[]{a1, a2, cmd, bar};
8181
}
8282

8383
String[] argsEnv = { "foo=bar" };

0 commit comments

Comments
 (0)