Skip to content

Commit c512ef2

Browse files
chromium: Backport missing dependency in NewTabPage (#815)
Dependency is missing in NewTabPage module. This can cause random build errors. Error occurrence depends on the order in which packages were build. It seems to occur more frequently with lower BB_NUMBER_THREADS values. Signed-off-by: Daniel Semkowicz <dse@thaumatec.com>
1 parent 40ebd7f commit c512ef2

File tree

2 files changed

+28
-0
lines changed

2 files changed

+28
-0
lines changed

meta-chromium/recipes-browser/chromium/chromium-gn.inc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ SRC_URI += "\
2121
file://backport/IWYU-for-content-browser-generic_sensor-fra.patch \
2222
file://backport/IWYU-for-g-c-service-shared_image-ozone_ima.patch \
2323
file://backport/Make-toolchain_supports_rust_thin_lto-configurable.patch \
24+
file://backport/NewTabPage-Add-missing-dep-to-cr_components.patch \
2425
"
2526
# Non-specific patches.
2627
SRC_URI += "\
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
From bd53e2fcd2ff2ab5f9726753b827e7f958ad1041 Mon Sep 17 00:00:00 2001
2+
From: dpapad <dpapad@chromium.org>
3+
Date: Wed, 27 Mar 2024 23:05:52 +0000
4+
Subject: [PATCH] Backport "NewTabPage: Add missing dep to
5+
cr_components/history_clusters/."
6+
7+
This fixes transient build error caused by missing dependency.
8+
The patch will be included in upstream's 125 release.
9+
10+
Upstream-Status: Backport [https://crrev.com/c/5402989]
11+
Signed-off-by: Daniel Semkowicz <dse@thaumatec.com>
12+
---
13+
chrome/browser/resources/new_tab_page/BUILD.gn | 1 +
14+
1 file changed, 1 insertion(+)
15+
16+
diff --git a/chrome/browser/resources/new_tab_page/BUILD.gn b/chrome/browser/resources/new_tab_page/BUILD.gn
17+
index db4708a51c522..96612c978bcb6 100644
18+
--- a/chrome/browser/resources/new_tab_page/BUILD.gn
19+
+++ b/chrome/browser/resources/new_tab_page/BUILD.gn
20+
@@ -97,6 +97,7 @@ build_webui("build") {
21+
"//ui/webui/resources/cr_components/color_change_listener:build_ts",
22+
"//ui/webui/resources/cr_components/customize_themes:build_ts",
23+
"//ui/webui/resources/cr_components/help_bubble:build_ts",
24+
+ "//ui/webui/resources/cr_components/history_clusters:build_ts",
25+
"//ui/webui/resources/cr_components/most_visited:build_ts",
26+
"//ui/webui/resources/cr_components/omnibox:build_ts",
27+
"//ui/webui/resources/cr_components/page_image_service:build_ts",

0 commit comments

Comments
 (0)