Skip to content

Commit bdde7ca

Browse files
krajshr-project
authored andcommitted
chromium: Refresh musl patches
Drop patches which are not needed anymore Signed-off-by: Khem Raj <raj.khem@gmail.com>
1 parent 488f6bd commit bdde7ca

13 files changed

+38
-159
lines changed

meta-chromium/recipes-browser/chromium/chromium-gn.inc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,7 @@ SRC_URI_append_libc-musl = "\
3434
file://musl/musl_gnu_libc-version.patch \
3535
file://musl/musl_resolver.patch \
3636
file://musl/musl_off64_t.patch \
37-
file://musl/musl_lss-match_syscalls.patch \
3837
file://musl/musl_crashpad.patch \
39-
file://musl/musl_replace_libc_fpstate.patch \
4038
file://musl/musl_fix_stack_trace.patch \
4139
file://musl/musl_portable_msghdr.patch \
4240
file://musl/musl_no__environ.patch \

meta-chromium/recipes-browser/chromium/files/musl/musl_breakpad.patch

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com>
66

77
--- a/third_party/breakpad/breakpad/src/common/linux/elf_core_dump.h
88
+++ b/third_party/breakpad/breakpad/src/common/linux/elf_core_dump.h
9-
@@ -36,6 +36,7 @@
10-
#include <elf.h>
9+
@@ -37,6 +37,7 @@
10+
#include <limits.h>
1111
#include <link.h>
1212
#include <stddef.h>
1313
+#include <sys/reg.h>

meta-chromium/recipes-browser/chromium/files/musl/musl_fix-stack.patch

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,16 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com>
66

77
--- a/third_party/blink/renderer/platform/wtf/stack_util.cc
88
+++ b/third_party/blink/renderer/platform/wtf/stack_util.cc
9-
@@ -30,7 +30,7 @@ size_t GetUnderestimatedStackSize() {
9+
@@ -29,7 +29,7 @@ size_t GetUnderestimatedStackSize() {
1010
// FIXME: On Mac OSX and Linux, this method cannot estimate stack size
1111
// correctly for the main thread.
1212

13-
-#if defined(__GLIBC__) || defined(OS_ANDROID) || defined(OS_FREEBSD) || \
14-
+#if defined(OS_LINUX) || defined(OS_ANDROID) || defined(OS_FREEBSD) || \
13+
-#elif defined(__GLIBC__) || defined(OS_ANDROID) || defined(OS_FREEBSD) || \
14+
+#elif defined(OS_LINUX) || defined(OS_ANDROID) || defined(OS_FREEBSD) || \
1515
defined(OS_FUCHSIA)
1616
// pthread_getattr_np() can fail if the thread is not invoked by
1717
// pthread_create() (e.g., the main thread of blink_unittests).
18-
@@ -98,7 +98,7 @@ size_t GetUnderestimatedStackSize() {
18+
@@ -97,7 +97,7 @@ return Threading::ThreadStackSize();
1919
}
2020

2121
void* GetStackStart() {

meta-chromium/recipes-browser/chromium/files/musl/musl_fix_stack_trace.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com>
1111

1212
--- a/base/debug/stack_trace.cc
1313
+++ b/base/debug/stack_trace.cc
14-
@@ -233,14 +233,14 @@ std::string StackTrace::ToString() const
14+
@@ -225,14 +225,14 @@ std::string StackTrace::ToString() const
1515
}
1616
std::string StackTrace::ToStringWithPrefix(const char* prefix_string) const {
1717
std::stringstream stream;

meta-chromium/recipes-browser/chromium/files/musl/musl_gnu_libc-version.patch

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com>
77

88
--- a/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
99
+++ b/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
10-
@@ -46,8 +46,9 @@
10+
@@ -51,8 +51,9 @@
1111
#endif // defined(OS_ANDROID) && defined(__arm__)
1212

1313
#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
@@ -18,16 +18,16 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com>
1818
#include "base/linux_util.h"
1919
#include "base/strings/string_split.h"
2020
#include "base/strings/string_util.h"
21-
@@ -238,7 +239,7 @@ void RecordStartupMetrics() {
22-
shell_integration::NUM_DEFAULT_STATES);
21+
@@ -229,7 +230,7 @@ void RecordStartupMetrics() {
22+
#endif
2323
}
2424

2525
-#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
2626
+#if defined(__GLIBC__) && !defined(OS_CHROMEOS)
27-
void RecordLinuxDistro() {
28-
UMALinuxDistro distro_result = UMA_LINUX_DISTRO_UNKNOWN;
29-
30-
@@ -348,7 +349,7 @@ void RecordLinuxDistro() {
27+
void RecordLinuxDistroSpecific(const std::string& version_string,
28+
size_t parts,
29+
const char* histogram_name) {
30+
@@ -308,7 +309,7 @@ void RecordLinuxDistro() {
3131
#endif // defined(OS_LINUX) && !defined(OS_CHROMEOS)
3232

3333
void RecordLinuxGlibcVersion() {
@@ -36,12 +36,12 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com>
3636
base::Version version(gnu_get_libc_version());
3737

3838
UMALinuxGlibcVersion glibc_version_result = UMA_LINUX_GLIBC_NOT_PARSEABLE;
39-
@@ -569,7 +570,7 @@ void ChromeBrowserMainExtraPartsMetrics:
40-
constexpr base::TaskTraits background_task_traits = {
41-
base::ThreadPool(), base::MayBlock(), base::TaskPriority::BEST_EFFORT,
39+
@@ -565,7 +566,7 @@ void ChromeBrowserMainExtraPartsMetrics:
40+
constexpr base::TaskTraits kBestEffortTaskTraits = {
41+
base::MayBlock(), base::TaskPriority::BEST_EFFORT,
4242
base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN};
4343
-#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
4444
+#if defined(__GLIBC__) && !defined(OS_CHROMEOS)
45-
base::PostTask(FROM_HERE, background_task_traits,
46-
base::BindOnce(&RecordLinuxDistro));
45+
base::ThreadPool::PostTask(FROM_HERE, kBestEffortTaskTraits,
46+
base::BindOnce(&RecordLinuxDistro));
4747
#endif

meta-chromium/recipes-browser/chromium/files/musl/musl_libc_malloc.patch

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com>
77

88
--- a/base/process/memory_linux.cc
99
+++ b/base/process/memory_linux.cc
10-
@@ -132,7 +132,7 @@ bool UncheckedMalloc(size_t size, void**
11-
(!defined(LIBC_GLIBC) && !defined(USE_TCMALLOC))
10+
@@ -151,7 +151,7 @@ bool UncheckedMalloc(size_t size, void**
11+
(!defined(LIBC_GLIBC) && !BUILDFLAG(USE_TCMALLOC))
1212
*result = malloc(size);
13-
#elif defined(LIBC_GLIBC) && !defined(USE_TCMALLOC)
13+
#elif defined(LIBC_GLIBC) && !BUILDFLAG(USE_TCMALLOC)
1414
- *result = __libc_malloc(size);
1515
+ *result = malloc(size);
16-
#elif defined(USE_TCMALLOC)
16+
#elif BUILDFLAG(USE_TCMALLOC)
1717
*result = tc_malloc_skip_new_handler(size);
1818
#endif

meta-chromium/recipes-browser/chromium/files/musl/musl_lss-match_syscalls.patch

Lines changed: 0 additions & 42 deletions
This file was deleted.

meta-chromium/recipes-browser/chromium/files/musl/musl_no_execinfo.patch

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com>
1414
#include <execinfo.h>
1515
#endif
1616

17-
@@ -86,7 +86,7 @@ void DemangleSymbols(std::string* text)
17+
@@ -88,7 +88,7 @@ void DemangleSymbols(std::string* text)
1818
// Note: code in this function is NOT async-signal safe (std::string uses
1919
// malloc internally).
2020

@@ -23,7 +23,7 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com>
2323
std::string::size_type search_from = 0;
2424
while (search_from < text->size()) {
2525
// Look for the start of a mangled symbol, from search_from.
26-
@@ -133,7 +133,7 @@ class BacktraceOutputHandler {
26+
@@ -135,7 +135,7 @@ class BacktraceOutputHandler {
2727
virtual ~BacktraceOutputHandler() = default;
2828
};
2929

@@ -32,7 +32,7 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com>
3232
void OutputPointer(void* pointer, BacktraceOutputHandler* handler) {
3333
// This should be more than enough to store a 64-bit number in hex:
3434
// 16 hex digits + 1 for null-terminator.
35-
@@ -812,7 +812,7 @@ size_t CollectStackTrace(void** trace, s
35+
@@ -827,7 +827,7 @@ size_t CollectStackTrace(void** trace, s
3636
// NOTE: This code MUST be async-signal safe (it's used by in-process
3737
// stack dumping signal handler). NO malloc or stdio is allowed here.
3838

@@ -41,7 +41,7 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com>
4141
// Though the backtrace API man page does not list any possible negative
4242
// return values, we take no chance.
4343
return base::saturated_cast<size_t>(backtrace(trace, count));
44-
@@ -825,13 +825,13 @@ void StackTrace::PrintWithPrefix(const c
44+
@@ -840,13 +840,13 @@ void StackTrace::PrintWithPrefix(const c
4545
// NOTE: This code MUST be async-signal safe (it's used by in-process
4646
// stack dumping signal handler). NO malloc or stdio is allowed here.
4747

@@ -59,22 +59,6 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com>
5959
StreamBacktraceOutputHandler handler(os);
6060
--- a/third_party/swiftshader/third_party/llvm-subzero/build/Linux/include/llvm/Config/config.h
6161
+++ b/third_party/swiftshader/third_party/llvm-subzero/build/Linux/include/llvm/Config/config.h
62-
@@ -8,13 +8,13 @@
63-
#define BUG_REPORT_URL "http://llvm.org/bugs/"
64-
65-
/* Define to 1 to enable backtraces, and to 0 otherwise. */
66-
-#define ENABLE_BACKTRACES 1
67-
+#define ENABLE_BACKTRACES 0
68-
69-
/* Define to 1 to enable crash overrides, and to 0 otherwise. */
70-
#define ENABLE_CRASH_OVERRIDES 1
71-
72-
/* Define to 1 if you have the `backtrace' function. */
73-
-#define HAVE_BACKTRACE 1
74-
+#define HAVE_BACKTRACE 0
75-
76-
/* Define to 1 if you have the <CrashReporterClient.h> header file. */
77-
/* #undef HAVE_CRASHREPORTERCLIENT_H */
7862
@@ -55,7 +55,7 @@
7963
#define HAVE_ERRNO_H 1
8064

meta-chromium/recipes-browser/chromium/files/musl/musl_no_mallinfo.patch

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4,39 +4,26 @@ Upstream-Status: Pending
44
Signed-off-by: Khem Raj <raj.khem@gmail.com>
55
--- a/base/process/process_metrics_posix.cc
66
+++ b/base/process/process_metrics_posix.cc
7-
@@ -110,7 +110,7 @@ size_t ProcessMetrics::GetMallocUsage()
7+
@@ -119,7 +119,7 @@ size_t ProcessMetrics::GetMallocUsage()
88
malloc_statistics_t stats = {0};
99
malloc_zone_statistics(nullptr, &stats);
1010
return stats.size_in_use;
11-
-#elif defined(OS_LINUX) || defined(OS_ANDROID)
12-
+#elif defined(__GLIBC__) || defined(OS_ANDROID)
11+
-#elif defined(OS_LINUX) || defined(OS_CHROMEOS) || defined(OS_ANDROID)
12+
+#elif defined(__GLIBC__) || defined(OS_CHROMEOS) || defined(OS_ANDROID)
1313
struct mallinfo minfo = mallinfo();
1414
#if BUILDFLAG(USE_TCMALLOC)
1515
return minfo.uordblks;
1616
--- a/base/trace_event/malloc_dump_provider.cc
1717
+++ b/base/trace_event/malloc_dump_provider.cc
18-
@@ -132,7 +132,7 @@ bool MallocDumpProvider::OnMemoryDump(co
18+
@@ -163,7 +163,7 @@ bool MallocDumpProvider::OnMemoryDump(co
1919
}
2020
#elif defined(OS_FUCHSIA)
2121
// TODO(fuchsia): Port, see https://crbug.com/706592.
2222
-#else
2323
+#elif defined(__GLIBC__)
2424
struct mallinfo info = mallinfo();
25-
#if !defined(ADDRESS_SANITIZER) && !defined(THREAD_SANITIZER)
26-
// Sanitizers override mallinfo.
27-
--- a/third_party/swiftshader/third_party/llvm-7.0/configs/linux/include/llvm/Config/config.h
28-
+++ b/third_party/swiftshader/third_party/llvm-7.0/configs/linux/include/llvm/Config/config.h
29-
@@ -122,8 +122,9 @@
30-
/* #undef HAVE_MALLCTL */
31-
32-
/* Define to 1 if you have the `mallinfo' function. */
33-
+#ifdef __GLIBC__
34-
#define HAVE_MALLINFO 1
35-
-
36-
+#endif
37-
/* Define to 1 if you have the <malloc.h> header file. */
38-
#define HAVE_MALLOC_H 1
39-
25+
// In case of Android's jemalloc |arena| is 0 and the outer pages size is
26+
// reported by |hblkhd|. In case of dlmalloc the total is given by
4027
--- a/third_party/swiftshader/third_party/llvm-subzero/build/Linux/include/llvm/Config/config.h
4128
+++ b/third_party/swiftshader/third_party/llvm-subzero/build/Linux/include/llvm/Config/config.h
4229
@@ -130,7 +130,7 @@

meta-chromium/recipes-browser/chromium/files/musl/musl_no_mallopt.patch

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ Signed-off-by: Khem Raj <raj.khem@gmail.com>
99
// Set by allocator_shim_override_ucrt_symbols_win.h when the
1010
// shimmed _set_new_mode() is called.
1111
return g_is_win_shim_layer_initialized;
12-
-#elif defined(OS_LINUX) && BUILDFLAG(USE_TCMALLOC) && \
13-
+#elif defined(__GLIBC__) && BUILDFLAG(USE_TCMALLOC) && \
14-
!defined(MEMORY_TOOL_REPLACES_ALLOCATOR)
12+
-#elif (defined(OS_LINUX) || defined(OS_CHROMEOS)) && \
13+
+#elif (defined(__GLIBC__) || defined(OS_CHROMEOS)) && \
14+
BUILDFLAG(USE_TCMALLOC) && !defined(MEMORY_TOOL_REPLACES_ALLOCATOR)
1515
// From third_party/tcmalloc/chromium/src/gperftools/tcmalloc.h.
1616
// TODO(primiano): replace with an include once base can depend on allocator.

0 commit comments

Comments
 (0)