Skip to content

Commit 7f19768

Browse files
committed
chromium-: Do not use append with += operator
this is undefined behaviour, mant times devs used them together to get the missing space at the beginning of string which append/prepend needs but thats not intended behaviour Signed-off-by: Khem Raj <raj.khem@gmail.com>
1 parent 03a2663 commit 7f19768

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

meta-chromium/recipes-browser/chromium/chromium-gn.inc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -319,10 +319,10 @@ GN_ARGS:append:arm = ' \
319319
'
320320
# tcmalloc's atomicops-internals-arm-v6plus.h uses the "dmb" instruction that
321321
# is not available on (some?) ARMv6 models, which causes the build to fail.
322-
GN_ARGS:append:armv6 += 'use_allocator="none"'
322+
GN_ARGS:append:armv6 = ' use_allocator="none"'
323323
# The WebRTC code fails to build on ARMv6 when NEON is enabled.
324324
# https://bugs.chromium.org/p/webrtc/issues/detail?id=6574
325-
GN_ARGS:append:armv6 += 'arm_use_neon=false'
325+
GN_ARGS:append:armv6 = ' arm_use_neon=false'
326326

327327
# Disable glibc shims on musl
328328
# tcmalloc does not play well with musl as of M62 (and possibly earlier).

0 commit comments

Comments
 (0)