Skip to content

Commit 3d1351f

Browse files
author
Raphael Kubo da Costa
authored
chromium: Require clang 14.0.0 in do_check_llvm_version() (#753)
We have required clang 14 since the update to Chromium 115, so make sure the version check reflects this and points people to the right branch. Signed-off-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
1 parent c1615eb commit 3d1351f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

meta-chromium/recipes-browser/chromium/chromium-gn.inc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -388,12 +388,12 @@ do_create_v8_qemu_wrapper[dirs] = "${B}"
388388
addtask create_v8_qemu_wrapper after do_patch before do_configure
389389

390390
# Check the LLVMVERSION defined in the meta-clang layer. Given Chromium is
391-
# developed using new C++ features, the LLVMVERSION has to be >= 12. Otherwise,
391+
# developed using new C++ features, the LLVMVERSION has to be >= 14. Otherwise,
392392
# it is not guaranteed that Chromium will compile.
393393
python do_check_llvm_version () {
394394
from distutils.version import LooseVersion
395395

396-
min_llvm_version = "12.0.0"
396+
min_llvm_version = "14.0.0"
397397
llvm_version = d.getVar('LLVMVERSION', False)
398398
if not llvm_version:
399399
bb.warn("Unable to determine LLVM version. Chromium may not be compiled "
@@ -403,7 +403,7 @@ python do_check_llvm_version () {
403403
if LooseVersion(llvm_version) < LooseVersion(min_llvm_version):
404404
bb.fatal("Your LLVMVERSION (%s) is lower than the minimum required "
405405
"LLVMVERSION (%s). If you are using dunfell, make sure you "
406-
"use clang12 branch." % (llvm_version, min_llvm_version))
406+
"use dunfell-clang14 branch." % (llvm_version, min_llvm_version))
407407
}
408408
addtask check_llvm_version before do_configure
409409

0 commit comments

Comments
 (0)