Skip to content

Commit 3b4aeda

Browse files
committed
firefox: Fix build with gcc-13
* this isn't enough to build firefox with current rust 1.71.0 in oe-core I've tried to backport multiple changes like: https://bugzilla.mozilla.org/show_bug.cgi?id=1663715#c5 https://hg.mozilla.org/releases/mozilla-esr78/rev/5db8c1e9f643ec26fc93e7a3fc7a90c742b11030 https://hg.mozilla.org/releases/mozilla-esr78/rev/6445a3a0e81d6aeeaa976be784edf2de9fab84de https://hg.mozilla.org/mozilla-central/rev/e2cede25c027 https://phabricator.services.mozilla.com/D89473 https://hg.mozilla.org/mozilla-central/rev/da77d5528a08 https://phabricator.services.mozilla.com/D83816 * but it's neverending story of more and more fixes and esr68 is just too old and not worth spending more time on it (just to measure build time across different Yocto releases) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
1 parent 760f475 commit 3b4aeda

File tree

2 files changed

+44
-0
lines changed

2 files changed

+44
-0
lines changed
Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
From 2e395910adb6f7432fb2cfc4357589009270c7b0 Mon Sep 17 00:00:00 2001
2+
From: Martin Jansa <Martin.Jansa@gmail.com>
3+
Date: Wed, 16 Aug 2023 17:07:47 +0000
4+
Subject: [PATCH] Fix build with gcc-13
5+
6+
* fixes:
7+
firefox/68.9.0esr/firefox-68.9.0/firefox-build-dir/dist/include/mozilla/gfx/Rect.h:313:47: error: no member named 'int32_t' in namespace 'std'
8+
firefox/68.9.0esr/firefox-68.9.0/media/webrtc/signaling/src/sdp/RsdparsaSdpGlue.cpp:45:20: error: no member named 'uint8_t' in namespace 'std'
9+
firefox/68.9.0esr/firefox-68.9.0/media/webrtc/signaling/src/sdp/RsdparsaSdpGlue.cpp:58:20: error: no member named 'uint16_t' in namespace 'std'
10+
firefox/68.9.0esr/firefox-68.9.0/media/webrtc/signaling/src/sdp/RsdparsaSdpGlue.cpp:71:20: error: no member named 'uint32_t' in namespace 'std'
11+
12+
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
13+
---
14+
Upstream-Status: Pending
15+
16+
gfx/2d/Rect.h | 1 +
17+
media/webrtc/signaling/src/sdp/RsdparsaSdpGlue.cpp | 1 +
18+
2 files changed, 2 insertions(+)
19+
20+
diff --git a/gfx/2d/Rect.h b/gfx/2d/Rect.h
21+
index be89904..1fceb99 100644
22+
--- a/gfx/2d/Rect.h
23+
+++ b/gfx/2d/Rect.h
24+
@@ -15,6 +15,7 @@
25+
#include "mozilla/Maybe.h"
26+
27+
#include <cmath>
28+
+#include <cstdint>
29+
30+
namespace mozilla {
31+
32+
diff --git a/media/webrtc/signaling/src/sdp/RsdparsaSdpGlue.cpp b/media/webrtc/signaling/src/sdp/RsdparsaSdpGlue.cpp
33+
index 143bfc5..18666a6 100644
34+
--- a/media/webrtc/signaling/src/sdp/RsdparsaSdpGlue.cpp
35+
+++ b/media/webrtc/signaling/src/sdp/RsdparsaSdpGlue.cpp
36+
@@ -3,6 +3,7 @@
37+
/* This Source Code Form is subject to the terms of the Mozilla Public
38+
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
39+
* You can obtain one at http://mozilla.org/MPL/2.0/. */
40+
+#include <cstdint>
41+
#include <string>
42+
43+
#include "signaling/src/sdp/RsdparsaSdpInc.h"

meta-firefox/recipes-browser/firefox/firefox_68.9.0esr.bb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ SRC_URI = "https://ftp.mozilla.org/pub/firefox/releases/${PV}/source/firefox-${P
5757
file://wayland/egl/bug1571603-Disable-eglQueryString-nullptr-EGL_EXTENSIONS.patch \
5858
file://wayland/egl/0001-GLLibraryLoader-Use-given-symbol-lookup-function-fir.patch \
5959
file://wayland/egl/0001-Mark-GLFeature-framebuffer_multisample-as-unsupporte.patch \
60+
file://0001-Fix-build-with-gcc-13.patch \
6061
"
6162

6263
SRC_URI[sha256sum] = "935105e1a8a97d64daffb372690e2b566b5f07641f01470929dbbc82d20d4407"

0 commit comments

Comments
 (0)