Skip to content

Commit 6d0dbf6

Browse files
updated requierements and added all algorithms
1 parent 6a7d045 commit 6d0dbf6

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ joblib
88
dipy
99
matplotlib
1010
scienceplots
11-
cvxpy
11+
cvxpy==1.6.1
1212
zenodo-get
1313
pytest
1414
tqdm

src/standardized/TCML_TechnionIIT_SLS.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ class TCML_TechnionIIT_SLS(OsipiBase):
2121
required_bvalues = 4
2222
required_thresholds = [0,0] # Interval from "at least" to "at most", in case submissions allow a custom number of thresholds
2323
required_bounds = False
24-
required_bounds_optional = True # Bounds may not be required but are optional
24+
required_bounds_optional = False # Bounds may not be required but are optional
2525
required_initial_guess = False
2626
required_initial_guess_optional = True
2727
accepted_dimensions = 1 # Not sure how to define this for the number of accepted dimensions. Perhaps like the thresholds, at least and at most?
2828

2929

3030
# Supported inputs in the standardized class
31-
supported_bounds = True
31+
supported_bounds = False
3232
supported_initial_guess = True
3333
supported_thresholds = True
3434

@@ -47,9 +47,10 @@ def __init__(self, bvalues=None, thresholds=None, bounds=None, initial_guess=Non
4747

4848
def initialize(self, bounds, initial_guess, fitS0,thresholds):
4949
if bounds is None:
50-
print('warning, no bounds were defined, so default bounds are used of ([0.0003, 0.001, 0.009, 0],[0.008, 0.5,0.04, 3])')
50+
print('warning, only D* is bounded between 0.001 and 0.5)')
5151
self.bounds = ([0.0003, 0.001, 0.009, 0],[0.008, 0.5,0.04, 3])
5252
else:
53+
print('warning, although bounds are given, only D* is bounded)')
5354
bounds=bounds
5455
self.bounds = bounds
5556
if initial_guess is None:

tests/IVIMmodels/unit_tests/algorithms.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
"algorithms": [
33
"TCML_TechnionIIT_lsqlm",
44
"TCML_TechnionIIT_lsqtrf",
5+
"TCML_TechnionIIT_lsqBOBYQA",
6+
"TCML_TechnionIIT_SLS",
57
"ASD_MemorialSloanKettering_QAMPER_IVIM",
68
"ETP_SRI_LinearFitting",
79
"IAR_LU_biexp",

0 commit comments

Comments
 (0)