Skip to content

Commit 5961a4b

Browse files
committed
Fix range issues:
dquote> - hide the slider when the there is no range. dquote> - display current value instead of the max.
1 parent e40577e commit 5961a4b

File tree

3 files changed

+21
-29
lines changed

3 files changed

+21
-29
lines changed

website/dashboard/index.css

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,14 +91,13 @@ main {
9191
}
9292
.slider:hover {
9393
opacity: 1;
94-
width: 25px;
9594
height: 25px;
9695
cursor: pointer;
9796
box-shadow: 0 0 2px rgba(0, 0, 0, 0.5);
9897
}
9998

10099
.slider-value {
101-
margin-left: 10px;
100+
margin: 0 10px;
102101
font-weight: bold;
103102
color: #333;
104103
}

website/dashboard/index.html

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -41,18 +41,16 @@ <h1 class="bar-title">IVIM MRI Algorithm Fitting Dashboard</h1>
4141

4242
<div class="slider-container">
4343
<span class="slider-label">Upper Range:</span>
44-
<span class="slider-value">0</span>
4544
<button id="decrement-range" class="slider-button">-</button>
4645
<input type="range" id="range-slider" class="slider" min="2" max="100" step="1" value="2">
4746
<button id="increment-range" class="slider-button">+</button>
4847
<span id="range-value" class="slider-value">2</span>
4948
</div>
50-
<div class="slider-container">
49+
<div id="lower-slider" class="slider-container">
5150
<span class="slider-label">Lower Range:</span>
52-
<span class="slider-value">0</span>
53-
<button id="decrement-lower-range" class="slider-button">-</button>
51+
<button id="decrement-lower-range" class="slider-button">+</button>
5452
<input type="range" id="lower-range-slider" class="slider" min="2" max="100" step="2" value="2">
55-
<button id="increment-lower-range" class="slider-button">+</button>
53+
<button id="increment-lower-range" class="slider-button">-</button>
5654
<span id="lower-range-value" class="slider-value">2</span>
5755
</div>
5856
</div>
@@ -87,12 +85,11 @@ <h1 class="bar-title">IVIM MRI Algorithm Fitting Dashboard</h1>
8785
<button id="increment-range-region" class="slider-button">+</button>
8886
<span id="range-value-region" class="slider-value">2</span>
8987
</div>
90-
<div class="slider-container">
88+
<div id="region-lower-slider" class="slider-container">
9189
<span class="slider-label">Lower Range:</span>
92-
<span class="slider-value">0</span>
93-
<button id="decrement-lower-range-region" class="slider-button">-</button>
90+
<button id="decrement-lower-range-region" class="slider-button">+</button>
9491
<input type="range" id="lower-range-slider-region" class="slider" min="2" max="100" step="2" value="2">
95-
<button id="increment-lower-range-region" class="slider-button">+</button>
92+
<button id="increment-lower-range-region" class="slider-button">-</button>
9693
<span id="lower-range-value-region" class="slider-value">2</span>
9794
</div>
9895
</div>

website/dashboard/index.js

Lines changed: 14 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,8 @@ document.addEventListener('DOMContentLoaded', function() {
8181

8282
incrementRange.addEventListener('click', function() {
8383
let newValue = parseInt(rangeSlider.value) + 2;
84-
if (newValue <= rangeSlider.max) {
8584
rangeSlider.value = newValue;
8685
updateRange(newValue);
87-
}
8886
});
8987

9088
// Add event listeners to range slider and buttons
@@ -113,10 +111,8 @@ document.addEventListener('DOMContentLoaded', function() {
113111

114112
incrementRangeLower.addEventListener('click', function() {
115113
let newValue = parseInt(rangeSliderLower.value) + 2;
116-
if (newValue <= rangeSliderLower.max) {
117-
rangeSliderLower.value = newValue;
118-
updateRangeLower(newValue);
119-
}
114+
rangeSliderLower.value = newValue;
115+
updateRangeLower(newValue);
120116
});
121117

122118
// Add event listener to region select
@@ -173,10 +169,8 @@ document.addEventListener('DOMContentLoaded', function() {
173169

174170
incrementRangeRegion.addEventListener('click', function() {
175171
let newValue = parseInt(rangeSliderRegion.value) + 2;
176-
if (newValue <= rangeSliderRegion.max) {
177-
rangeSliderRegion.value = newValue;
178-
updateRangeRegion(newValue);
179-
}
172+
rangeSliderRegion.value = newValue;
173+
updateRangeRegion(newValue);
180174
});
181175

182176
// Add event listeners to range slider and buttons for region
@@ -205,10 +199,8 @@ document.addEventListener('DOMContentLoaded', function() {
205199

206200
incrementRangeLowerRegion.addEventListener('click', function() {
207201
let newValue = parseInt(rangeSliderLowerRegion.value) + 2;
208-
if (newValue <= rangeSliderLowerRegion.max) {
209-
rangeSliderLowerRegion.value = newValue;
210-
updateRangeLowerRegion(newValue);
211-
}
202+
rangeSliderLowerRegion.value = newValue;
203+
updateRangeLowerRegion(newValue);
212204
});
213205

214206
showLoading();
@@ -283,16 +275,20 @@ document.addEventListener('DOMContentLoaded', function() {
283275
const groundTruthList = jsonData
284276
.filter(obj => obj.SNR === selectedSNR)
285277
.map(obj => obj[selectedType.slice(0, -7)]);
286-
let estimatedRange = Math.abs(maxValue) / Math.min(...groundTruthList)
278+
let estimatedRange = Math.ceil(Math.abs(maxValue) / Math.min(...groundTruthList))
287279
let estimatedRangeLower = Math.abs(minValue) / Math.min(...groundTruthList)
280+
currentUpperValue = (Math.min(...groundTruthList) * selectedRange).toFixed(4)
281+
currentLowerValue = (-Math.min(...groundTruthList) * selectedRangeLower).toFixed(4)
288282
if (minValue < 0) {
289-
rangeValueLower.textContent = minValue.toFixed(4)
283+
rangeValueLower.textContent = currentLowerValue
284+
document.getElementById('lower-slider').style.visibility = 'visible';
290285
}
291286
else {
287+
document.getElementById('lower-slider').style.visibility = 'hidden';
292288
rangeValueLower.textContent = '0.0000'
293289
selectedRangeLower = 0;
294290
}
295-
rangeValue.textContent = maxValue.toFixed(4)
291+
rangeValue.textContent = currentUpperValue
296292
rangeSlider.max = Math.round(estimatedRange / 2) * 2
297293
rangeSliderLower.max = Math.round(estimatedRangeLower / 2) * 2
298294
let plots = [];
@@ -335,7 +331,7 @@ document.addEventListener('DOMContentLoaded', function() {
335331
title: `${type[selectedType]} Box Plots for ${selectedAlgorithm} algorithm with ${selectedSNR} SNR`,
336332
yaxis: {
337333
autorange: false,
338-
range: [-Math.min(...groundTruthList) * selectedRangeLower, Math.min(...groundTruthList) * selectedRange],
334+
range: [currentLowerValue, currentUpperValue],
339335
type: 'linear'
340336
}
341337
};

0 commit comments

Comments
 (0)