Oliver's approach

Dynamic scaling adjusted. Also boundaries adjusted
Remove normalisation as signal isnormalized.
Remove algorithm-specific tolerance boundaries such that default boundaries are used
Take medians of parameters as means give some machine precission error...

Author: oliverchampion

phantoms/MR_XCAT_qMRI/sim_ivim_sig.py

@@ -459,9 +459,9 @@ def parse_bvalues_file(file_path):
             signals = np.squeeze(voxels[int(voxels.shape[0] * voxel_selector_fraction)]).tolist()
             generic_data[name] = {
                 'noise': noise,
-                'D': np.mean(Dim[selector], axis=0),
-                'f': np.mean(fim[selector], axis=0),
-                'Dp': np.mean(Dpim[selector], axis=0),
+                'D': np.median(Dim[selector], axis=0),
+                'f': np.median(fim[selector], axis=0),
+                'Dp': np.median(Dpim[selector], axis=0),
                 'data': signals
             }
         generic_data['config'] = {

tests/IVIMmodels/unit_tests/algorithms.json

@@ -16,86 +16,32 @@
     ],
     "IAR_LU_biexp": {
         "tolerances": {
-            "rtol": {
-                "f": 5,
-                "D": 5,
-                "Dp": 25
-            },
-            "atol": {
-                "f": 1e-2,
-                "D": 1e-2,
-                "Dp": 1e-1
-            }
+
         }
     },
     "IAR_LU_modified_mix": {
         "tolerances": {
-            "rtol": {
-                "f": 5,
-                "D": 5,
-                "Dp": 25
-            },
-            "atol": {
-                "f": 1e-2,
-                "D": 1e-2,
-                "Dp": 1e-1
-            }
+
         }
     },
     "IAR_LU_modified_topopro": {
         "tolerances": {
-            "rtol": {
-                "f": 5,
-                "D": 5,
-                "Dp": 25
-            },
-            "atol": {
-                "f": 1e-2,
-                "D": 1e-2,
-                "Dp": 1e-1
-            }
+
         }
     },
     "IAR_LU_segmented_2step": {
         "tolerances": {
-            "rtol": {
-                "f": 5,
-                "D": 5,
-                "Dp": 25
-            },
-            "atol": {
-                "f": 1e-2,
-                "D": 1e-2,
-                "Dp": 1e-1
-            }
+
         }
     },
     "IAR_LU_segmented_3step": {
         "tolerances": {
-            "rtol": {
-                "f": 5,
-                "D": 5,
-                "Dp": 25
-            },
-            "atol": {
-                "f": 1e-2,
-                "D": 1e-2,
-                "Dp": 1e-1
-            }
+
         }
     },
     "IAR_LU_subtracted": {
         "tolerances": {
-            "rtol": {
-                "f": 5,
-                "D": 5,
-                "Dp": 25
-            },
-            "atol": {
-                "f": 1e-2,
-                "D": 1e-2,
-                "Dp": 1e-1
-            }
+
         }
     },
     "ETP_SRI_LinearFitting": {
@@ -117,51 +63,31 @@
                 "Dp": 0
             },
             "dynamic_rtol": {
-                "offset": 0,
-                "noise": 0,
-                "ratio": 0,
-                "noiseCrossRatio": 10,
-                "f": 1,
+                "offset": 0.001,
+                "noise": 200,
+                "scale_f": false,
+                "f": 2,
                 "D": 1,
-                "Dp": 2
+                "Dp": 3
             },
             "dynamic_atol": {
                 "offset": 5e-2,
-                "noise": 0,
-                "ratio": 0,
-                "noiseCrossRatio": 10,
+                "noise": 10,
+                "scale_f": false,
                 "f": 1,
-                "D": 1,
+                "D": 0.001,
                 "Dp": 2
             }
         }
     },
     "OGC_AmsterdamUMC_biexp_segmented": {
         "tolerances": {
-            "rtol": {
-                "f": 5,
-                "D": 5,
-                "Dp": 25
-            },
-            "atol": {
-                "f": 1e-2,
-                "D": 1e-2,
-                "Dp": 1e-1
-            }
+
         }
     },
     "OJ_GU_seg": {
         "tolerances": {
-            "rtol": {
-                "f": 5,
-                "D": 5,
-                "Dp": 25
-            },
-            "atol": {
-                "f": 1e-2,
-                "D": 1e-2,
-                "Dp": 1e-1
-            }
+
         }
     }
 }