You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#401 should solve the problems reported in #398 with the transport solver. However, the reports issued are still wrong, basically computeInjectedProduced() should be rewritten to fix this.
I suggest two changes that would make these things more robust:
Use some kind of source specification object to clearly specify for any injection source its phase, instead of using the somewhat magical 'transport source' convention (negative is total outflow, positive is first phase inflow).
Instead of trying to figure out after the face how much was injected or produced (as the function computeInjectedProduced() does now), which only can be correct for implicit methods, all transport solvers should instead report these numbers themselves.