[IMP] : pre-commit auto fixes

Author: jcadhoc

requirements.txt

@@ -0,0 +1,2 @@
+# generated from manifests external_dependencies
+openupgradelib

server_action_mass_edit/__manifest__.py

@@ -2,7 +2,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 {
     "name": "Mass Editing",
-    "version": "18.0.1.1.1",
+    "version": "19.0.1.0.0",
     "author": "Serpent Consulting Services Pvt. Ltd., "
     "Tecnativa, "
     "GRAP, "

server_action_mass_edit/tests/test_mass_editing.py

@@ -141,7 +141,7 @@ def test_wiz_fields_view_get(self):
         arch = result.get("arch", "")
         self.assertTrue(
             "selection__email" not in arch,
-            "Fields view get must return architecture w/o fields" "created dynamicaly",
+            "Fields view get must return architecture w/o fieldscreated dynamicaly",
         )
         view_id.mass_server_action_id = self.mass_editing_user
         result = self.MassEditingWizard.with_context(
@@ -151,7 +151,7 @@ def test_wiz_fields_view_get(self):
         arch = result.get("arch", "")
         self.assertTrue(
             "selection__email" in arch,
-            "Fields view get must return architecture with fields" "created dynamicaly",
+            "Fields view get must return architecture with fieldscreated dynamicaly",
         )
 
         # test the code path where we extract an embedded tree for o2m fields
@@ -252,7 +252,7 @@ def test_mass_edit_partner_title(self):
         self.assertEqual(
             self.partner_title.with_context(lang="de_DE").shortcut,
             "Bots.",
-            "Translation for Partner Title's Abbreviation " "was not loaded properly.",
+            "Translation for Partner Title's Abbreviation was not loaded properly.",
         )
         # Removing partner title with mass edit action
         vals = {"selection__shortcut": "remove"}
@@ -268,7 +268,7 @@ def test_mass_edit_partner_title(self):
         self.assertEqual(
             self.partner_title.with_context(lang="de_DE").shortcut,
             False,
-            "Translation for Partner Title's Abbreviation " "was not removed properly.",
+            "Translation for Partner Title's Abbreviation was not removed properly.",
         )
 
     def test_mass_edit_email(self):

server_action_mass_edit/wizard/mass_editing_wizard.py

@@ -87,27 +87,48 @@ def onchange(self, values, field_names, fields_spec):
         server_action = self.env["ir.actions.server"].sudo().browse(server_action_id)
         if not server_action:
             return super().onchange(values, field_names, fields_spec)
-        dynamic_fields = {}
 
+        # Collect dynamic field names to filter them out
+        dynamic_field_names = set()
         for line in server_action.mapped("mass_edit_line_ids"):
-            values["selection__" + line.field_id.name] = "ignore"
-            values[line.field_id.name] = False
-
-            # Make sure there is an entry for the default value retrieved above.
-            dynamic_fields["selection__" + line.field_id.name] = fields.Selection(
-                [("ignore", _("Don't touch"))], default="ignore"
-            )
-            dynamic_fields[line.field_id.name] = fields.Text([()], default=False)
+            selection_field = "selection__" + line.field_id.name
+            field_name = line.field_id.name
+            dynamic_field_names.add(selection_field)
+            dynamic_field_names.add(field_name)
+
+            # Set default values for dynamic fields
+            if selection_field not in values:
+                values[selection_field] = "ignore"
+            if field_name not in values:
+                values[field_name] = False
+
+        # Filter out dynamic fields before calling super
+        filtered_values = {
+            key: value
+            for key, value in values.items()
+            if key not in dynamic_field_names
+        }
+        filtered_field_names = [
+            fname for fname in field_names if fname not in dynamic_field_names
+        ]
+        filtered_fields_spec = {
+            fname: spec
+            for fname, spec in fields_spec.items()
+            if fname not in dynamic_field_names
+        }
 
-        self._fields.update(dynamic_fields)
+        res = super().onchange(
+            filtered_values, filtered_field_names, filtered_fields_spec
+        )
 
-        res = super().onchange(values, field_names, fields_spec)
-        if not res["value"]:
-            value = {key: value for key, value in values.items() if value is not False}
-            res["value"] = value
+        # Ensure dynamic field values are included in the response
+        if not res.get("value"):
+            res["value"] = {}
 
-        for field in dynamic_fields:
-            self._fields.pop(field)
+        # Add dynamic field values to the result
+        for field_name in dynamic_field_names:
+            if field_name in values:
+                res["value"][field_name] = values[field_name]
 
         view_temp = (
             self.env["ir.ui.view"]