Investigate if finalizeQueryParamChange needs to be messed with

[NullVoxPopuli]

I ran in to an issue where I can't just willy-nilly transitionTo('path', { queryParams: { whatever I want } }, as it seems like the queryParams are checked against whatever is defined on the controller's queryParams array.

To really make this addon complete, the restriction needs to be "dealt with".

https://github.com/emberjs/ember.js/blob/master/packages/%40ember/-internals/routing/lib/system/route.ts#L2437-L2528

[mattmarcum]

As long as you set the queryParams on the route then you can leave out the controller all together:
https://github.com/emberjs/ember.js/blob/master/packages/%40ember/-internals/routing/lib/system/route.ts#L2208

But if you define a controller at all then you probably need to set the queryParams there too.

[NullVoxPopuli]

ah good find! I wonder if we need to add these to the route/controller behind the scenes manually/dynamically as a queryParam decorator is used

[Arijit-Roy]

Things have changed since this conversation. The above link does not work anymore. Do we have a solution that still works ?