Apply Sonarcloud recommendations (#569)

Author: No767

bot/cogs/meta.py

@@ -119,23 +119,16 @@ async def about(self, ctx: commands.Context) -> None:
         total_members = 0
         total_unique = len(self.bot.users)
 
-        text = 0
-        voice = 0
         guilds = 0
         for guild in self.bot.guilds:
             guilds += 1
             if guild.unavailable:
                 continue
 
             total_members += guild.member_count or 0
-            for channel in guild.channels:
-                if isinstance(channel, discord.TextChannel):
-                    text += 1
-                elif isinstance(channel, discord.VoiceChannel):
-                    voice += 1
 
         memory_usage = self.process.memory_full_info().uss / 1024**2
-        cpu_usage = self.process.cpu_percent() / psutil.cpu_count() # type: ignore # I'm not sure why pyright is complaining about this
+        cpu_usage = self.process.cpu_percent() / psutil.cpu_count()  # type: ignore # I'm not sure why pyright is complaining about this
 
         revisions = self.get_last_commits()
 

bot/cogs/redirects.py

@@ -239,7 +239,6 @@ async def resolved(self, ctx: GuildContext) -> None:
             # Permissions.add_reaction and Permissions.read_message_history is required
             await ctx.message.add_reaction(discord.PartialEmoji(name="\U00002705"))
             await self.mark_as_resolved(channel, ctx.author)
-            return
         else:
             prompt_message = f"<@!{channel.owner_id}>, would you like to mark this thread as solved? If this thread is not marked as resolved, then it will not be resolved. This has been requested by {ctx.author.mention}."
             view = ConfirmResolvedView(

bot/libs/utils/time.py

@@ -12,7 +12,7 @@ def __init__(self, value: int):
 
     def __format__(self, format_spec: str) -> str:
         v = self.value
-        singular, sep, plural = format_spec.partition("|")
+        singular, _, plural = format_spec.partition("|")
         plural = plural or f"{singular}s"
         if abs(v) != 1:
             return f"{v} {plural}"