Carelink delivery suspended state, and possibly other states

[kukuchta]

From the point of view of the Carelink Follower user, there are some binary states in the downloaded data that could be added to the main chart. For my 740G pump, the one important is the Delivery Suspended state that marks the time periods when the insulin dosing is shut off due to the low sensor readings.

I imagine there are also some additional states for the hybrid 780g pump, like the temporary BG target, smart guard activation periods and so on. Im just guessing here. Not sure if there are such binary states for other data sources.

Im experimenting with this feature and wanted ask for opinion on how it is aligned with xDrip codebase and general concept.

First I added another SQL table and model called Notifications. I felt it was necessary, because currently Carelink notifications are stored in Treatment table as a treatment entry with a note but without any carbs or insulin dose. This seems more like an workaround than actual way of handling pump alerts and notifications. Every notification would have its own Type and boolean value.
Such Notifications are quite generic and do not need to be specific for Carelink. They would be parsed and populated by any data source.

Then, those Notifications would be used in BgGraphBuilder to conditionally produce some additional Lines. Each Notification with given notification Type produces two datapoints for given Line. If binary state is turned on, we take the timestamp and we add points with y=0, then y=highMark (simulating the rising edge). If the state is turned of, we add those points in different order (falling edge). This approach is also quite generic and would be usable with other data sources.

Do you think such changes are useful? Or there is too little gain for given amount of changes?

For Delivery Stopped indication my result looks like this (additional orange regions):

[user-hash]

It would be very useful to have basal insulin displayed in xDrip using Carelink follower.
I wonder if we can display basal insulin delivery like on AAPS?

I have checked the Carelink report and it displays basal insulin in a similar way, I am just not sure how the collector works or how to extract the values.
Do you have any Carelink collector errors in your xDrip log?