Skip to content

Aggressive patchFlatListProps #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yangm97 opened this issue Sep 11, 2021 · 2 comments
Open

Aggressive patchFlatListProps #12

yangm97 opened this issue Sep 11, 2021 · 2 comments

Comments

@yangm97
Copy link

yangm97 commented Sep 11, 2021 •
edited
Loading

When props.refreshing is undefined refreshControl shouldn't be be injected.

Right now patchFlatListProps changes the behavior of FlatLists which aren't supposed to have a refreshControl. It also causes some type warnings to be thrown in development.

https://snack.expo.dev/wcIw8L47u
@yangm97
Copy link
Author

yangm97 commented Sep 11, 2021

Also breaks horizontal FlatLists https://snack.expo.dev/x_4Fv3WDC

@NiciusB
Copy link
Owner

NiciusB commented Sep 11, 2021 •
edited
Loading

You're right. I will fix it ASAP. It should only inject when onRefresh is defined, as per the FlatList docs

@indraneelpatil indraneelpatil mentioned this issue Apr 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NiciusB @yangm97