Skip to content

Commit 035d9a1

Browse files
authored
Merge pull request #106 from Nexters/fix/background-image
[FIX] Background 이미지가 언제나 화면 전체를 채우도록 수정
2 parents dfeecc7 + 2e39d36 commit 035d9a1

File tree

5 files changed

+8
-9
lines changed

5 files changed

+8
-9
lines changed

app/src/main/AndroidManifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
<application
1313
android:name=".ILabApplication"
14-
android:allowBackup="true"
14+
android:allowBackup="false"
1515
android:dataExtractionRules="@xml/data_extraction_rules"
1616
android:fullBackupContent="@xml/backup_rules"
1717
android:icon="@mipmap/ic_launcher"

build-logic/src/main/kotlin/com/nexters/ilab/android/Config.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ internal object ApplicationConfig {
44
const val MinSdk = 26
55
const val TargetSdk = 34
66
const val CompileSdk = 34
7-
const val VersionCode = 3
8-
const val VersionName = "1.0.2"
7+
const val VersionCode = 4
8+
const val VersionName = "1.0.3"
99
val JavaVersion = org.gradle.api.JavaVersion.VERSION_17
1010
const val JavaVersionAsInt = 17
1111
}

core/ui/src/main/kotlin/com/nexters/ilab/core/ui/component/Image.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ fun BackgroundImage(
9797
resId: Int,
9898
contentDescription: String,
9999
modifier: Modifier = Modifier,
100-
contentScale: ContentScale = ContentScale.Fit,
100+
contentScale: ContentScale = ContentScale.Crop,
101101
) {
102102
if (LocalInspectionMode.current) {
103103
Box(modifier = Modifier.fillMaxSize())

feature/home/src/main/kotlin/com/nexters/ilab/android/feature/home/HomeScreen.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ import com.nexters.ilab.core.ui.component.PagerIndicator
7171
import com.nexters.ilab.core.ui.component.ServerErrorDialog
7272
import com.nexters.ilab.core.ui.component.TopAppBarNavigationType
7373

74-
// TODO 하단 스타일과 스타일 입력 화면 연동
7574
@Composable
7675
internal fun HomeRoute(
7776
padding: PaddingValues,

feature/login/src/main/kotlin/com/nexters/ilab/android/feature/login/LoginScreen.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ internal fun LoginRoute(
7474
resource.getString(R.string.unknown_error_message)
7575
}
7676
}
77+
7778
is SocketTimeoutException -> resource.getString(R.string.server_error_message)
7879
else -> resource.getString(R.string.unknown_error_message)
7980
},
@@ -139,10 +140,6 @@ internal fun LoginScreen(
139140
onLoginClick: () -> Unit,
140141
) {
141142
Box(modifier = Modifier.fillMaxSize()) {
142-
if (uiState.isLoading) {
143-
LoadingIndicator(modifier = Modifier.fillMaxSize())
144-
}
145-
146143
BackgroundImage(
147144
resId = R.drawable.bg_login_screen,
148145
contentDescription = "Background Image for Login Screen",
@@ -153,6 +150,9 @@ internal fun LoginScreen(
153150
LoginContent(
154151
onLoginClick = onLoginClick,
155152
)
153+
if (uiState.isLoading) {
154+
LoadingIndicator()
155+
}
156156
}
157157
}
158158

0 commit comments

Comments
 (0)