Accept local tx even when syncing (#8242)

Author: benaadams

src/Nethermind/Nethermind.TxPool.Test/TxPoolTests.cs

@@ -1151,7 +1151,7 @@ public void should_accept_access_list_transactions_only_when_eip2930_enabled([Va
         }
 
         [Test]
-        public void should_accept_only_when_synced([Values(false, true)] bool isSynced)
+        public void should_accept_only_when_synced([Values(false, true)] bool isSynced, [Values(false, true)] bool isLocal)
         {
             if (!isSynced)
             {
@@ -1165,9 +1165,9 @@ public void should_accept_only_when_synced([Values(false, true)] bool isSynced)
                 .WithChainId(TestBlockchainIds.ChainId)
                 .SignedAndResolved(_ethereumEcdsa, TestItem.PrivateKeyA).TestObject;
             EnsureSenderBalance(tx);
-            AcceptTxResult result = _txPool.SubmitTx(tx, TxHandlingOptions.PersistentBroadcast);
-            _txPool.GetPendingTransactionsCount().Should().Be(isSynced ? 1 : 0);
-            result.Should().Be(isSynced ? AcceptTxResult.Accepted : AcceptTxResult.Syncing);
+            AcceptTxResult result = _txPool.SubmitTx(tx, isLocal ? TxHandlingOptions.PersistentBroadcast : TxHandlingOptions.None);
+            _txPool.GetPendingTransactionsCount().Should().Be((isSynced || isLocal) ? 1 : 0);
+            result.Should().Be((isSynced || isLocal) ? AcceptTxResult.Accepted : AcceptTxResult.Syncing);
         }
 
         [Test]

src/Nethermind/Nethermind.TxPool/TxPool.cs

@@ -419,7 +419,13 @@ public void RemovePeer(PublicKey nodeId)
 
         public AcceptTxResult SubmitTx(Transaction tx, TxHandlingOptions handlingOptions)
         {
-            if (!AcceptTxWhenNotSynced && _headInfo.IsSyncing) return AcceptTxResult.Syncing;
+            if (!AcceptTxWhenNotSynced &&
+                _headInfo.IsSyncing &&
+                // If local tx allow it to be accepted even when syncing
+                (handlingOptions & TxHandlingOptions.PersistentBroadcast) == 0)
+            {
+                return AcceptTxResult.Syncing;
+            }
 
             Metrics.PendingTransactionsReceived++;