You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation of the workflow triggering allows one to specify the webhook url, which can theoretically be in any namespace. However, the sensors always get generated into the KUBERNETES_NAMESPACE, which is the same namespace as the workflow. We run our workflows in multiple namespaces, but have our eventbus, event sources, and sensors in a single namespace. The changes required to allow for this would be minimal:
argo_client.py - change ._namespace in this function to ._sensor_namespace and set that to some config value or fall back to KUBERNETES_NAMESPACE
This would create a argo events sensor in one namespace (i.e. argo-events) and then trigger a workflow in the namespace that the workflow was ran in.
I could put together a PR pretty quickly if you are open to these changes. I successfully sent the argo event to a webhook in a separate namespace and triggered a workflow in the original namespace with these three changes.
The text was updated successfully, but these errors were encountered:
The current implementation of the workflow triggering allows one to specify the webhook url, which can theoretically be in any namespace. However, the sensors always get generated into the
KUBERNETES_NAMESPACE
, which is the same namespace as the workflow. We run our workflows in multiple namespaces, but have our eventbus, event sources, and sensors in a single namespace. The changes required to allow for this would be minimal:._namespace
in this function to._sensor_namespace
and set that to some config value or fall back toKUBERNETES_NAMESPACE
This would create a argo events sensor in one namespace (i.e.
argo-events
) and then trigger a workflow in the namespace that the workflow was ran in.I could put together a PR pretty quickly if you are open to these changes. I successfully sent the argo event to a webhook in a separate namespace and triggered a workflow in the original namespace with these three changes.
The text was updated successfully, but these errors were encountered: