Refactors and consolidates email templates (#763)

* Refactors and consolidates email templates

* Renames generic to notification list

Author: mvilanova

src/dispatch/messaging/email/templates/document_evergreen_reminder.mjml

@@ -3,14 +3,11 @@
 <mj-section background-color="#ffffff" padding-left="15px" padding-right="15px">
   <mj-column width="100%">
   {% for item in items %}
-    <mj-text>
-      <ul style="list-style-type:none; padding-left: 0;">
-        <li>
-          <b><a href="{{ item.title_link }}" target="_blank" rel="noopener noreferrer">{{ item.title }}</a></b
-          >
-        </li>
-        <li>{{ item.text }}</li>
-      </ul>
+    <mj-text color="#212b35" font-weight="bold" font-size="20px">
+        <a href="{{ item.title_link }}" target="_blank" rel="noopener noreferrer">{{ item.title }}</a>
+    </mj-text>
+    <mj-text color="#212b35" font-size="16px">
+        {{ item.text }}
     </mj-text>
   {% endfor %}
   </mj-column>

src/dispatch/messaging/email/templates/notification.mjml

@@ -28,15 +28,15 @@ def get_template(message_type: MessageType):
         MessageType.incident_participant_welcome: ("notification.mjml", None),
         MessageType.incident_tactical_report: ("tactical_report.mjml", None),
         MessageType.incident_task_reminder: (
-            "task_notification.mjml",
+            "notification_list.mjml",
             INCIDENT_TASK_REMINDER_DESCRIPTION,
         ),
         MessageType.document_evergreen_reminder: (
-            "document_evergreen_reminder.mjml",
+            "notification_list.mjml",
             DOCUMENT_EVERGREEN_REMINDER_DESCRIPTION,
         ),
         MessageType.incident_feedback_daily_digest: (
-            "feedback_notification.mjml",
+            "notification_list.mjml",
             INCIDENT_FEEDBACK_DAILY_DIGEST_DESCRIPTION,
         ),
     }

src/dispatch/messaging/email/templates/feedback_notification.mjml renamed to src/dispatch/messaging/email/templates/notification_list.mjml

@@ -285,13 +285,13 @@ class MessageType(str, Enum):
 Thanks for participating in the {{name}} ("{{title}}") incident. We would appreciate if you could rate your experience and provide feedback."""
 
 INCIDENT_TYPE_CHANGE_DESCRIPTION = """
-The incident type has been changed from *{{ incident_type_old }}* to *{{ incident_type_new }}*."""
+The incident type has been changed from {{ incident_type_old }} to {{ incident_type_new }}."""
 
 INCIDENT_STATUS_CHANGE_DESCRIPTION = """
-The incident status has been changed from *{{ incident_status_old }}* to *{{ incident_status_new }}*."""
+The incident status has been changed from {{ incident_status_old }} to {{ incident_status_new }}."""
 
 INCIDENT_PRIORITY_CHANGE_DESCRIPTION = """
-The incident priority has been changed from *{{ incident_priority_old }}* to *{{ incident_priority_new }}*."""
+The incident priority has been changed from {{ incident_priority_old }} to {{ incident_priority_new }}."""
 
 INCIDENT_NAME_WITH_ENGAGEMENT = {
     "title": "{{name}} Incident Notification",

src/dispatch/messaging/email/templates/task_notification.mjml

@@ -78,7 +78,7 @@ def send_tactical_report_to_tactical_group(
     # we load the incident instance
     incident = incident_service.get(db_session=db_session, incident_id=incident_id)
 
-    subject = f"{incident.name.upper()} - Tactical Report"
+    subject = f"{incident.name} - Tactical Report"
     plugin.instance.send(
         incident.notifications_group.email,
         INCIDENT_TACTICAL_REPORT,
@@ -111,7 +111,7 @@ def send_executive_report_to_notifications_group(
     # we load the incident instance
     incident = incident_service.get(db_session=db_session, incident_id=incident_id)
 
-    subject = f"{incident.name.upper()} - Executive Report"
+    subject = f"{incident.name} - Executive Report"
     plugin.instance.send(
         incident.notifications_group.email,
         INCIDENT_EXECUTIVE_REPORT,