Rename

Author: airbreather

doc/release-notes.md

@@ -1,7 +1,7 @@
 # NetTopologySuite.IO.GPX Release Notes
 
 ## [0.3.1](https://github.com/NetTopologySuite/NetTopologySuite.IO.GPX/milestone/8)
-- `GpxReaderSettings` now has an opt-in `IgnoreMissingVersionFailure` property, to allow reading files without a `version` attribute ([#27](https://github.com/NetTopologySuite/NetTopologySuite.IO.GPX/issues/27)).
+- `GpxReaderSettings` now has an opt-in `AllowMissingVersionAttribute` property, to allow reading files without a `version` attribute ([#27](https://github.com/NetTopologySuite/NetTopologySuite.IO.GPX/issues/27)).
 
 ## [0.3.0](https://github.com/NetTopologySuite/NetTopologySuite.IO.GPX/milestone/4)
 - `GpxReaderSettings` now has a `DefaultCreatorIfMissing` property to use for filling in a missing `GpxMetadata.Creator` value, to help read values saved from legacy versions of IHM ([#23](https://github.com/NetTopologySuite/NetTopologySuite.IO.GPX/issues/23)).

src/NetTopologySuite.IO.GPX/GpxReader.cs

@@ -100,7 +100,7 @@ public static void Read(XmlReader reader, GpxReaderSettings settings, GpxVisitor
             settings = settings ?? new GpxReaderSettings();
             while (reader.ReadToFollowing("gpx", Helpers.GpxNamespace))
             {
-                bool versionAccepted = settings.IgnoreMissingVersionFailure;
+                bool versionAccepted = settings.AllowMissingVersionAttribute;
                 string creator = settings.DefaultCreatorIfMissing;
                 for (bool hasAttribute = reader.MoveToFirstAttribute(); hasAttribute; hasAttribute = reader.MoveToNextAttribute())
                 {

src/NetTopologySuite.IO.GPX/GpxReaderSettings.cs

@@ -38,6 +38,6 @@ public sealed class GpxReaderSettings
         /// declaration, even though such files would not pass XSD validation (see
         /// NetTopologySuite/NetTopologySuite.IO.GPX#27).
         /// </summary>
-        public bool IgnoreMissingVersionFailure { get; set; }
+        public bool AllowMissingVersionAttribute { get; set; }
     }
 }

tests/NetTopologySuite.IO.GPX.Tests/GpxFileTests.cs

@@ -219,7 +219,7 @@ public void MissingVersionShouldBeValid_OptIn()
 ";
             Assert.ThrowsAny<XmlException>(() => GpxFile.Parse(GpxText, null));
 
-            var settings = new GpxReaderSettings { IgnoreMissingVersionFailure = true };
+            var settings = new GpxReaderSettings { AllowMissingVersionAttribute = true };
             var file = GpxFile.Parse(GpxText, settings);
             Assert.Equal("someone", file.Metadata.Creator);
         }