You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
This is a small API change in that is a little annoying to have to check whether strides are row or column major before passing to the tensor constructor at
.
TorchInductor tracks this internally, so it is easier for us to check whether the shape + stride are contiguous and then passing it along.
Describe the solution you'd like
Ideally just take a shape and stride arg rather than having to convert to a shape, layout tag pair and then have the constructor interpret these.
Describe alternatives you've considered
I added a shim layer in inductor that does this, so it's nbd, but just a nice-to-have, perhaps having two versions of the API wouldn't hurt here.
Is your feature request related to a problem? Please describe.
This is a small API change in that is a little annoying to have to check whether strides are row or column major before passing to the tensor constructor at
cutlass/python/cutlass/backend/evt/ir/tensor.py
Line 54 in 5e49724
TorchInductor tracks this internally, so it is easier for us to check whether the shape + stride are contiguous and then passing it along.
Describe the solution you'd like
Ideally just take a shape and stride arg rather than having to convert to a shape, layout tag pair and then have the constructor interpret these.
Describe alternatives you've considered
I added a shim layer in inductor that does this, so it's nbd, but just a nice-to-have, perhaps having two versions of the API wouldn't hurt here.
cc @eellison, @henrylhtsang
The text was updated successfully, but these errors were encountered: