-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[FEA] Passing the copy type as a parameter to copy
#1672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
You can use |
If you would like to work on a PR, that would be lovely! @ccecka CC |
I suspect much of this can be accomplished by just renaming |
Sure, I'll push up a PR today. I'll see if just replacing the defaultcopy to be universalcopy is enough. |
This issue has been labeled |
This issue has been labeled |
Kind of a small change.
So I was looking at
#1231
and I was wondering if it made sense to refactor the code so that it will accept the type of copy they want to rely on like so
copy(gmem_tiled_copy, SM80_CP_ASYNC_CACHEALWAYS<float>{}, tAgA, tAsA)
so that way you can have the user be aware of what's going on internally. Right now if you useDefaultCopy
for example it'll dispatch to that instruction which requires the code to have more synchronization which is a little unintuitive.You might be able to get the copy type inferred from
gmem_tiled_copy
but passing it as an explicit parameter is probably much easier.I'm wondering if there's any flaws/problems with doing this? Perhaps the default should always be
copy(gmem_tiled_copy, DefaultCopy{}, tAgA, tAsA)
.I could work on a PR for implementing this if it's beneficial. Would like to know ahead of time if this is even desired or if there are problems with this approach before I commit my time to a PR though.
The text was updated successfully, but these errors were encountered: