Merge pull request #554 from NVIDIA/am/fix-type

Fix invalid type for image when cache is disabled

Author: amaslenn

src/cloudai/util/docker_image_cache_manager.py

@@ -157,7 +157,7 @@ def check_docker_image_exists(self, docker_image_url: str, docker_image_filename
 
         # If not caching locally, return True. Defer checking URL accessibility to srun.
         if not self.system.cache_docker_images_locally:
-            return DockerImageCacheResult(True, Path(docker_image_url), "")
+            return DockerImageCacheResult(True, None, "")
 
         docker_image_path = Path(docker_image_url)
         if docker_image_path.is_file() and docker_image_path.exists():

tests/test_docker_image_cache_manager.py

@@ -192,9 +192,7 @@ def test_ensure_docker_image_no_local_cache(slurm_system: SlurmSystem):
     result = manager.ensure_docker_image("docker.io/hello-world", "docker_image.sqsh")
 
     assert result.success
-    assert result.docker_image_path is not None
-    assert str(result.docker_image_path) == "docker.io/hello-world"
-    assert not result.docker_image_path.is_absolute()
+    assert result.docker_image_path is None
     assert result.message == ""
 
 

tests/test_slurm_installer.py

@@ -81,6 +81,13 @@ def test_is_installed_when_cache_exists(self, installer: SlurmInstaller):
         assert res.message == f"Cached Docker image already exists at {cached_file}."
         assert d.installed_path == cached_file
 
+    def test_cache_disabled(self, installer: SlurmInstaller):
+        d = DockerImage("fake_url/img")
+        installer.system.cache_docker_images_locally = False
+        res = installer.is_installed_one(d)
+        assert res.success
+        assert d.installed_path == d.url
+
 
 class TestInstallOneGitRepo:
     @pytest.fixture