Add CTK 12.9.1 / Ubuntu 24.04 container recipe #1028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n class matx::detail::matxDnSVDCUDAPlan_t and base class matx::detail::matxDnCUDASolver_t
cliffburdick
reviewed
Aug 1, 2025
| "--gpus=all", | ||
| "--entrypoint", | ||
| "fixuid" | ||
| "--gpus=all" |
There was a problem hiding this comment.
I was running into issues with this one, but I think it's fine for now. It would be nice to build on machines without GPUs too
cliffburdick
reviewed
Aug 1, 2025
| } | ||
| }, | ||
| "terminal.integrated.defaultProfile.linux": "bash" | ||
| }, | ||
| "extensions": [ |
There was a problem hiding this comment.
Can you add the cursor C++ extensions and remove the MS versions?
cliffburdick
reviewed
Aug 1, 2025
| from hpccm.building_blocks import gnu, mlnx_ofed, nvshmem, cmake | ||
| from hpccm.primitives import baseimage | ||
|
|
||
| DOXYGEN_VER = "1.9.6" |
There was a problem hiding this comment.
This version is quite old and they make quite a few C++ updates. Should we try a newer one?
cliffburdick
reviewed
Aug 1, 2025
| fi | ||
|
|
||
| docker run --platform=$MATX_PLATFORM \ | ||
| --privileged \ |
There was a problem hiding this comment.
Technically the privileged stuff was there for DPDK, but we can leave it in
cliffburdick
reviewed
Aug 1, 2025
| @@ -580,6 +580,10 @@ static __MATX_INLINE__ SVDMethod GetCUDASVDMethod(const ATensor &a) { | |||
| return method; | |||
| } | |||
|
|
|||
| #ifndef DOXYGEN_ONLY | |||
| // Hide this from doxygen, otherwise we get | |||
There was a problem hiding this comment.
When I hit these errors usually either updating doxygen or using the Sphinx equivalent parser fixed it.
cliffburdick
approved these changes
Aug 1, 2025
|
/build |
|
/build |
2 similar comments
|
/build |
|
/build |
|
/build |
2 similar comments
|
/build |
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.