Release 0.7.1 - do not open ws for empty endpoint

Author: Shaquu

package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-red-contrib-unifi-os",
-  "version": "0.7.0",
+  "version": "0.7.1",
   "description": "Nodes to access UniFi data using endpoints and websockets",
   "main": "build/nodes/unifi.js",
   "scripts": {

src/nodes/WebSocket.ts

@@ -40,11 +40,16 @@ module.exports = (RED: NodeAPI) => {
         action: string,
         callback: () => void
     ): Promise<void> => {
-        self.ws?.removeAllListeners()
-        self.ws?.close(1000, `Node ${action}`)
-        self.ws?.terminate()
-        log.debug(`ws ${self.ws?.['id']} closed`)
-        self.ws = undefined
+        if (self.ws) {
+            self.ws.removeAllListeners()
+            self.ws.close(1000, `Node ${action}`)
+            self.ws.terminate()
+            log.debug(`ws ${self.ws?.['id']} closed`)
+            self.ws = undefined
+        } else {
+            log.debug('ws already closed')
+        }
+
         callback()
     }
 
@@ -249,7 +254,10 @@ module.exports = (RED: NodeAPI) => {
         const log = logger('UniFi', 'WebSocket', self.name, self)
 
         self.endpoint = self.config.endpoint
-        await setupWebsocket(self)
+
+        if (self.endpoint?.trim().length) {
+            await setupWebsocket(self)
+        }
 
         self.on('input', async (msg) => {
             log.debug('Received input message: ' + util.inspect(msg))
@@ -260,16 +268,23 @@ module.exports = (RED: NodeAPI) => {
                     msg.payload
                 )
 
-            if (
-                self.endpoint != (inputPayload.endpoint ?? self.config.endpoint)
-            ) {
-                self.endpoint = inputPayload.endpoint ?? self.config.endpoint
-                await stopWebsocket(self, log, 'reconfigured', () =>
-                    setupWebsocket(self)
-                )
+            const newEndpoint = inputPayload.endpoint ?? self.config.endpoint
+
+            if (newEndpoint?.trim().length) {
+                if (self.endpoint != newEndpoint) {
+                    self.endpoint = newEndpoint
+
+                    await stopWebsocket(self, log, 'reconfigured', () =>
+                        setupWebsocket(self)
+                    )
+                } else {
+                    log.debug(
+                        `Input ignored, endpoint did not change: ${self.endpoint}, ${inputPayload.endpoint}, ${self.config.endpoint}`
+                    )
+                }
             } else {
                 log.debug(
-                    `Input ignored, endpoint did not change: ${self.endpoint}, ${inputPayload.endpoint}, ${self.config.endpoint}`
+                    `Input ignored, new endpoint is empty: ${self.endpoint}, ${inputPayload.endpoint}, ${self.config.endpoint}`
                 )
             }
         })

src/types/WebSocketNodeConfigType.ts

@@ -8,7 +8,7 @@ type WebSocketNodeConfigType = NodeDef & {
     /**
      * UniFi web socket endpoint. For example /proxy/network/wss/s/default/events or /api/ws/system
      */
-    endpoint: string
+    endpoint?: string
     /**
      * How long in milliseconds to wait until trying to reconnect web socket client
      */

src/types/WebSocketNodeType.ts

@@ -6,7 +6,7 @@ import WebSocket from 'ws'
 type WebSocketNodeType = Node & {
     config: WebSocketNodeConfigType
     accessControllerNode: AccessControllerNodeType
-    endpoint: string
+    endpoint?: string
     ws?: WebSocket & { id?: string }
 }