Skip to content

[8pt] load_dotenv consistency #1679

@RobHanna-NOAA

Description

@RobHanna-NOAA

We have a number of places that load config files using .env files. Historically, they assumed a file named simply .env exists beside the script file. No notes existed about need. This also triggers inconsistencies. We have been slowly changing all files that use .env to be:

  • Set as a default argument available for override in the script. A good example is eval_plots.py -e flag.
    • Notice is defaults to /data/config/fim_enviro_values.env by design. Some files have already been updated to this convention but more are needed.
  • Scripts that need the update are:
    • preprocess_ahps_usgs.py
    • preprocess_ahps_usgs_grids.py (we are checking if this is still used)
    • preprocess_ahps_nws.py
    • fimr_to_benchmark.py (we are checking if this is still used)
    • generate_nws_list.py
    • tools_shared_functions.py
  • For tools_shared_functions.py/get_env_paths: No scripts use this functions. Recommend getting rid of it as each script has different enviro values it needs from the config file.
  • In the fim_enviro_values.env file, it has at least two hardcode input paths. This does not support versioning. Those should be corrected as well, but either something inline the script file that allows for pathing or via bash_variables (if it makes sense).
    • If we do end up removing / changing the fim_enviro_values.env for pathing such as EVALUATED_SITES_CSV, we need to make sure this file is also copied to Dev1 as it uses some values here as well.
  • Also add more notes inline about sample usage with practical examples, what the tool is for, what it outputs, etc.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions