[trace-view] Fixed breakpoints problem in no-source bytecode files (#22048)

## Description 

This PR fixes a problem with setting breakpoints in disassembly files
that do not have a corresponding source file.

The problem was related to the fact that a no-source disassembly file is
treated as a source file by the runtime if no actual source file exists.
This was reflected everywhere but not in the code responsible for
checking validity of breakpoints...

## Test plan 

A test verifying that no-source disassembly file is debugged correctly
was modified. This test was previously incorrect actually (note that the
stack never showed disassembly file frame) so in addition to adding
breakpoint test, stepping through source/disassembly combination has
also been fixed.

Author: awelc

external-crates/move/crates/move-analyzer/trace-adapter/src/runtime.ts

@@ -810,9 +810,15 @@ export class Runtime extends EventEmitter {
         if (fileExt !== MOVE_FILE_EXT && fileExt !== BCODE_FILE_EXT) {
             return [];
         }
-        const tracedLines = fileExt === MOVE_FILE_EXT
-            ? this.trace.tracedSrcLines.get(filePath)
-            : this.trace.tracedBcodeLines.get(filePath);
+        // For a source file, `tracedLines` will be in `tracedSrcLines`,
+        // but if no source file exists (only bytecode) then it may be
+        // in `tracedSourceLines` for the bytecode file as well, so simply
+        // use the path for search. If not found, and it's the bytecode file
+        // then search in `tracedBcodeLines` as well.
+        let tracedLines = this.trace.tracedSrcLines.get(filePath);
+        if (!tracedLines && fileExt === BCODE_FILE_EXT) {
+            tracedLines = this.trace.tracedBcodeLines.get(filePath);
+        }
         // Set all breakpoints to invalid and validate the correct ones in the loop,
         // otherwise let them all be invalid if there are no traced lines.
         // Valid breakpoints are those that are on lines that have at least

external-crates/move/crates/move-analyzer/trace-adapter/tests/disassembly_no_source/build/disassembly_no_source/debug_info/m2.json

@@ -1,8 +1,9 @@
 // Tests a scenario when there is no source file for a given module
 // but there is a disasembled bytecode file for this module. Note
-// that module m2 does not have source map (or source file in the build
+// that module m2 does not have source debug info (or source file in the build
 // directory) but it has a disassembled bytecode file which is automatically
-// used during debugging.
+// used during debugging. It also tests setting breakpoints in bytecode
+// files that do not have a corresponding source file.
 module disassembly_no_source::m;
 
 use disassembly_no_source::m2::foo;

external-crates/move/crates/move-analyzer/trace-adapter/tests/disassembly_no_source/build/disassembly_no_source/debug_info/m2.mvd

@@ -1,12 +1,38 @@
 current frame stack:
   function: test (m.move:12)
     scope 0 :
+line breakpoints
+  m2.mvb
+    12
 current frame stack:
   function: test (m.move:12)
     scope 0 :
-  function: foo (m2.move:6)
+  function: foo (m2.mvb:8)
     scope 0 :
       p : 42
       type: u64
 
+line breakpoints
+  m2.mvb
+    12
 current frame stack:
+  function: test (m.move:12)
+    scope 0 :
+  function: foo (m2.mvb:11)
+    scope 0 :
+  function: bar (m3.move:4)
+    scope 0 :
+      p : 84
+      type: u64
+
+line breakpoints
+  m2.mvb
+    12
+current frame stack:
+  function: test (m.move:12)
+    scope 0 :
+  function: foo (m2.mvb:12)
+    scope 0 :
+line breakpoints
+  m2.mvb
+    12

external-crates/move/crates/move-analyzer/trace-adapter/tests/disassembly_no_source/build/disassembly_no_source/sources/m2.move

@@ -1,6 +1,9 @@
 const path = require('path');
 let action = (runtime) => {
+    const pkgName = path.basename(__dirname);
+    const filePath = path.join(__dirname, 'build', pkgName, 'disassembly', `m2.mvb`);
     let res = '';
+    runtime.setLineBreakpoints(filePath, [ 12 ]);
     // we are in a functino that has source file
     res += runtime.toString();
     // step into a function which does not have source file
@@ -12,6 +15,9 @@ let action = (runtime) => {
     runtime.step(false);
     runtime.step(false);
     res += runtime.toString();
+    // continue until you reach breakpoint at the end of the caller function
+    runtime.continue();
+    res += runtime.toString();
     return res;
 };
 run_spec(__dirname, action);

external-crates/move/crates/move-analyzer/trace-adapter/tests/disassembly_no_source/sources/m.move

@@ -5,7 +5,7 @@
     "publisher": "mysten",
     "icon": "images/move.png",
     "license": "Apache-2.0",
-    "version": "0.0.6",
+    "version": "0.0.7",
     "preview": true,
     "repository": {
         "url": "https://github.com/MystenLabs/sui.git",