fixup: protocol configs comments

Author: amnn

crates/sui-indexer-alt-e2e-tests/tests/graphql/epochs/protocol_configs.move

@@ -7,9 +7,16 @@
 
 //# run-graphql
 { # Protocol Configs that don't exist (because they haven't been used in the
-  # chain being indexed)
-  protocolConfigs(version: 69) { protocolVersion }
-  protocolConfigs(version: 71) { protocolVersion }
+  # chain being indexed) -- their config lists will be empty.
+  before: protocolConfigs(version: 69) {
+    protocolVersion
+    configs { key value }
+  }
+
+  after: protocolConfigs(version: 71) {
+    protocolVersion
+    configs { key value }
+  }
 }
 
 //# run-graphql

crates/sui-indexer-alt-e2e-tests/tests/graphql/epochs/protocol_configs.snap

@@ -10,31 +10,22 @@ task 1, line 6:
 //# create-checkpoint
 Checkpoint created: 1
 
-task 2, lines 8-13:
+task 2, lines 8-20:
 //# run-graphql
 Response: {
-  "data": null,
-  "errors": [
-    {
-      "message": "Fields \"version\" conflict because they have differing arguments. Use different aliases on the fields to fetch both if this was intentional.",
-      "locations": [
-        {
-          "line": 3,
-          "column": 3
-        },
-        {
-          "line": 4,
-          "column": 3
-        }
-      ],
-      "extensions": {
-        "code": "GRAPHQL_VALIDATION_FAILED"
-      }
+  "data": {
+    "before": {
+      "protocolVersion": 69,
+      "configs": []
+    },
+    "after": {
+      "protocolVersion": 71,
+      "configs": []
     }
-  ]
+  }
 }
 
-task 3, lines 15-21:
+task 3, lines 22-28:
 //# run-graphql
 Response: {
   "data": {
@@ -51,7 +42,7 @@ Response: {
   }
 }
 
-task 4, lines 23-33:
+task 4, lines 30-40:
 //# run-graphql
 Response: {
   "data": {

crates/sui-indexer-alt-graphql/src/api/types/protocol_configs.rs

@@ -148,7 +148,7 @@ impl FlagContent {
         let configs: Vec<StoredFeatureFlag> = conn
             .results(p::kv_feature_flags.filter(p::protocol_version.eq(protocol_version as i64)))
             .await
-            .context("Fail to fetch protocol configs")?;
+            .context("Fail to fetch feature flags")?;
 
         Ok(Self(
             configs