Do not report execution times for cancelled transactions (#22080)

Author: mystenmark

crates/sui-core/src/authority.rs

@@ -1295,6 +1295,7 @@ impl AuthorityState {
 
         epoch_store.record_local_execution_time(
             certificate.data().transaction_data(),
+            &effects,
             timings,
             execution_start_time.elapsed(),
         );

crates/sui-core/src/authority/authority_per_epoch_store.rs

@@ -49,7 +49,7 @@ use sui_types::crypto::{
 };
 use sui_types::digests::{ChainIdentifier, TransactionEffectsDigest};
 use sui_types::dynamic_field::get_dynamic_field_from_store;
-use sui_types::effects::TransactionEffects;
+use sui_types::effects::{TransactionEffects, TransactionEffectsAPI};
 use sui_types::error::{SuiError, SuiResult};
 use sui_types::executable_transaction::{
     TrustedExecutableTransaction, VerifiedExecutableTransaction,
@@ -1230,6 +1230,7 @@ impl AuthorityPerEpochStore {
     pub fn record_local_execution_time(
         &self,
         tx: &TransactionData,
+        effects: &TransactionEffects,
         timings: Vec<ExecutionTiming>,
         total_duration: Duration,
     ) {
@@ -1238,6 +1239,10 @@ impl AuthorityPerEpochStore {
             return;
         };
 
+        if effects.status().is_cancelled() {
+            return;
+        }
+
         // Only record timings for PTBs with shared inputs.
         let TransactionKind::ProgrammableTransaction(ptb) = tx.kind() else {
             return;

crates/sui-types/src/execution_status.rs

@@ -416,6 +416,16 @@ impl ExecutionStatus {
             None
         }
     }
+
+    pub fn is_cancelled(&self) -> bool {
+        matches!(
+            self,
+            ExecutionStatus::Failure {
+                error: ExecutionFailureStatus::ExecutionCancelledDueToSharedObjectCongestion { .. },
+                ..
+            }
+        )
+    }
 }
 
 pub type CommandIndex = usize;