[move-ide] Added a fix to better handle mvr dependencies (#22150)

## Description 

By default, package manager runs all external resolvers on each build.
This slows down `move-analyzer` to the point of it becoming unusable.
This PR adds support for running external resolvers only on the fist
build of Move source code done by `move-analyzer` (a flag added to
package manager allows to unconditionally read from the lock file if it
exits, without checking its freshness).

## Test plan 

Verified that build time in VSCode drops from 2-3 seconds to ~100ms
withe MVR dependencies present

Author: awelc

external-crates/move/crates/move-analyzer/editors/code/package.json

@@ -5,7 +5,7 @@
   "publisher": "mysten",
   "icon": "images/move.png",
   "license": "Apache-2.0",
-  "version": "1.0.21",
+  "version": "1.0.22",
   "preview": true,
   "repository": {
     "url": "https://github.com/MystenLabs/sui.git",

external-crates/move/crates/move-analyzer/src/symbols/compilation.rs

@@ -162,12 +162,14 @@ pub fn get_compiled_pkg(
     lint: LintLevel,
     implicit_deps: Dependencies,
 ) -> Result<(Option<CompiledPkgInfo>, BTreeMap<PathBuf, Vec<Diagnostic>>)> {
+    let cached_deps_exist = has_precompiled_deps(pkg_path, packages_info.clone());
     let build_config = move_package::BuildConfig {
         test_mode: true,
         install_dir: Some(tempdir().unwrap().path().to_path_buf()),
         default_flavor: Some(Flavor::Sui),
         lint_flag: lint.into(),
-        skip_fetch_latest_git_deps: has_precompiled_deps(pkg_path, packages_info.clone()),
+        force_lock_file: cached_deps_exist,
+        skip_fetch_latest_git_deps: cached_deps_exist,
         implicit_dependencies: implicit_deps,
         ..Default::default()
     };

external-crates/move/crates/move-package/src/lib.rs

@@ -118,6 +118,11 @@ pub struct BuildConfig {
     /// Additional dependencies to be automatically included in every package
     #[clap(skip)]
     pub implicit_dependencies: Dependencies,
+
+    /// Forces use of lock file without checking if it needs to be updated
+    /// (regenerates it only if it doesn't exist)
+    #[clap(skip)]
+    pub force_lock_file: bool,
 }
 
 #[derive(
@@ -290,6 +295,7 @@ impl BuildConfig {
             writer,
             install_dir.clone(),
             self.implicit_dependencies.clone(),
+            self.force_lock_file,
         );
         let (dependency_graph, modified) = dep_graph_builder.get_graph(
             &DependencyKind::default(),

external-crates/move/crates/move-package/src/resolution/dependency_graph.rs

@@ -202,6 +202,9 @@ pub struct DependencyGraphBuilder<Progress: Write> {
     /// Set of implicit dependencies to add to every package
     /// Invariant: all dependencies are Internal deps with dep_override set
     implicit_deps: Dependencies,
+    /// Forces use of lock file without checking if it needs to be updated
+    /// (regenerates it only if it doesn't exist)
+    force_lock_file: bool,
 }
 
 impl<Progress: Write> DependencyGraphBuilder<Progress> {
@@ -210,6 +213,7 @@ impl<Progress: Write> DependencyGraphBuilder<Progress> {
         progress_output: Progress,
         install_dir: PathBuf,
         implicit_deps: Dependencies,
+        force_lock_file: bool,
     ) -> Self {
         for (name, dep) in implicit_deps.iter() {
             assert!(
@@ -224,6 +228,7 @@ impl<Progress: Write> DependencyGraphBuilder<Progress> {
             visited_dependencies: VecDeque::new(),
             install_dir,
             implicit_deps,
+            force_lock_file,
         }
     }
 
@@ -258,6 +263,30 @@ impl<Progress: Write> DependencyGraphBuilder<Progress> {
             })
             .unwrap_or(None);
 
+        let root_pkg_id = custom_resolve_pkg_id(&root_manifest).with_context(|| {
+            format!(
+                "Resolving package name for '{}'",
+                root_manifest.package.name
+            )
+        })?;
+
+        let root_pkg_name = root_manifest.package.name;
+        if self.force_lock_file {
+            if let Some((_, _, Some(lock_string))) = digest_and_lock_contents {
+                eprintln!("Force-reading from lock file");
+                return Ok((
+                    DependencyGraph::read_from_lock(
+                        root_path,
+                        root_pkg_id,
+                        root_pkg_name,
+                        &mut lock_string.as_bytes(), // safe since old_deps_digest exists
+                        None,
+                    )?,
+                    false,
+                ));
+            }
+        }
+
         // implicits deps should be skipped if the manifest contains any of them
         // explicitly (or if the manifest is for a system package).
         let explicit_implicits: Vec<&Symbol> = self
@@ -289,14 +318,6 @@ impl<Progress: Write> DependencyGraphBuilder<Progress> {
         }
 
         // collect sub-graphs for "regular" and "dev" dependencies
-        let root_pkg_id = custom_resolve_pkg_id(&root_manifest).with_context(|| {
-            format!(
-                "Resolving package name for '{}'",
-                root_manifest.package.name
-            )
-        })?;
-
-        let root_pkg_name = root_manifest.package.name;
         let (mut dep_graphs, resolved_id_deps, mut dep_names, mut overrides) = self
             .collect_graphs(
                 parent,

external-crates/move/crates/move-package/src/resolution/mod.rs

@@ -39,6 +39,7 @@ pub fn download_dependency_repos<Progress: Write>(
         progress_output,
         install_dir,
         build_options.implicit_dependencies.clone(),
+        build_options.force_lock_file,
     );
     let (graph, _) = dep_graph_builder.get_graph(
         &DependencyKind::default(),

external-crates/move/crates/move-package/tests/test_additional_addresses.rs

@@ -32,6 +32,7 @@ fn test_additional_addresses() {
         std::io::sink(),
         tempdir().unwrap().path().to_path_buf(),
         /* implicit_deps */ Dependencies::default(),
+        /* force_lock_file */ false,
     );
     let (dg, _) = dep_graph_builder
         .get_graph(
@@ -95,6 +96,7 @@ fn test_additional_addresses_already_assigned_same_value() {
         std::io::sink(),
         tempdir().unwrap().path().to_path_buf(),
         /* implicit_deps */ Dependencies::default(),
+        /* force_lock_file */ false,
     );
     let (dg, _) = dep_graph_builder
         .get_graph(
@@ -144,6 +146,7 @@ fn test_additional_addresses_already_assigned_different_value() {
         std::io::sink(),
         tempdir().unwrap().path().to_path_buf(),
         /* implicit_deps */ Dependencies::default(),
+        /* force_lock_file */ false,
     );
     let (dg, _) = dep_graph_builder
         .get_graph(

external-crates/move/crates/move-package/tests/test_dependency_graph.rs

@@ -44,6 +44,7 @@ fn no_dep_graph() {
         std::io::sink(),
         tempfile::tempdir().unwrap().path().to_path_buf(),
         Dependencies::default(), /* implicit deps */
+        /* force_lock_file */ false,
     );
     let (graph, _) = dep_graph_builder
         .get_graph(
@@ -167,6 +168,7 @@ fn always_deps() {
         std::io::sink(),
         tempfile::tempdir().unwrap().path().to_path_buf(),
         /* implicit_deps */ Dependencies::default(),
+        /* force_lock_file */ false,
     );
     let (graph, _) = dep_graph_builder
         .get_graph(
@@ -584,6 +586,7 @@ fn immediate_dependencies() {
         std::io::sink(),
         tempfile::tempdir().unwrap().path().to_path_buf(),
         /* implicit_deps */ Dependencies::default(),
+        /* force_lock_file */ false,
     );
     let (graph, _) = dep_graph_builder
         .get_graph(

external-crates/move/crates/move-package/tests/test_sources/basic_no_deps/Move@compiled.snap

@@ -33,5 +33,6 @@ CompiledPackageInfo {
             lint: false,
         },
         implicit_dependencies: {},
+        force_lock_file: false,
     },
 }

external-crates/move/crates/move-package/tests/test_sources/basic_no_deps/Move@resolved.snap

@@ -42,6 +42,7 @@ ResolvedGraph {
             lint: false,
         },
         implicit_dependencies: {},
+        force_lock_file: false,
     },
     package_table: {
         "test": Package {

external-crates/move/crates/move-package/tests/test_sources/basic_no_deps_address_assigned/Move@compiled.snap

@@ -35,5 +35,6 @@ CompiledPackageInfo {
             lint: false,
         },
         implicit_dependencies: {},
+        force_lock_file: false,
     },
 }