Fix debug assert (#22064)

slow.rs workload transactions shouldn't abort, but they can be cancelled

Author: mystenmark

crates/sui-benchmark/src/lib.rs

@@ -24,7 +24,6 @@ use sui_json_rpc_types::{
     SuiTransactionBlockEffectsAPI, SuiTransactionBlockResponseOptions,
 };
 use sui_sdk::{SuiClient, SuiClientBuilder};
-use sui_types::effects::{TransactionEffectsAPI, TransactionEvents};
 use sui_types::gas::GasCostSummary;
 use sui_types::programmable_transaction_builder::ProgrammableTransactionBuilder;
 use sui_types::quorum_driver_types::EffectsFinalityInfo;
@@ -45,6 +44,10 @@ use sui_types::{
     base_types::{AuthorityName, SuiAddress},
     sui_system_state::SuiSystemStateTrait,
 };
+use sui_types::{
+    effects::{TransactionEffectsAPI, TransactionEvents},
+    execution_status::ExecutionFailureStatus,
+};
 use tokio::time::sleep;
 use tracing::{info, warn};
 
@@ -152,6 +155,28 @@ impl ExecutionEffects {
         }
     }
 
+    pub fn is_cancelled(&self) -> bool {
+        match self {
+            ExecutionEffects::FinalizedTransactionEffects(effects, ..) => {
+                match effects.data().status() {
+                    sui_types::execution_status::ExecutionStatus::Success => false,
+                    sui_types::execution_status::ExecutionStatus::Failure {
+                        error:
+                            ExecutionFailureStatus::ExecutionCancelledDueToSharedObjectCongestion {
+                                ..
+                            },
+                        ..
+                    } => true,
+                    _ => false,
+                }
+            }
+            ExecutionEffects::SuiTransactionBlockEffects(sui_tx_effects) => {
+                let status = format!("{}", sui_tx_effects.status());
+                status.contains("ExecutionCancelledDueToSharedObjectCongestion")
+            }
+        }
+    }
+
     pub fn status(&self) -> String {
         match self {
             ExecutionEffects::FinalizedTransactionEffects(effects, ..) => {

crates/sui-benchmark/src/workloads/slow.rs

@@ -45,7 +45,7 @@ impl std::fmt::Display for SlowTestPayload {
 impl Payload for SlowTestPayload {
     fn make_new_payload(&mut self, effects: &ExecutionEffects) {
         debug_assert!(
-            effects.is_ok(),
+            effects.is_ok() || effects.is_cancelled(),
             "Slow transactions should never abort: {effects:?}",
         );