Skip to content
This repository was archived by the owner on May 31, 2021. It is now read-only.

no colons supported in property values #55

Closed
roomsg opened this issue Jun 29, 2015 · 4 comments
Closed

no colons supported in property values #55

roomsg opened this issue Jun 29, 2015 · 4 comments

Comments

@roomsg
Copy link

roomsg commented Jun 29, 2015

would be nice to be able to have properties with colons (":") in it (eg: url).

Currrently not supported (v0.12), IllegalArgumentException is thrown:
"staticAdditionalField must be of the format key:value, where key is the additional field key (therefore should have a leading underscore), and value is a static string. e.g. _node_name:www013"
@Moocar
Copy link
Owner

Moocar commented Jul 7, 2015

Agreed. The hack would be to split on the first \: but I'm thinking that explicit </key> </value> fields will be more future proof.

@Moocar Moocar mentioned this issue Jul 8, 2015
Merged
@Moocar
Copy link
Owner

Moocar commented Jul 8, 2015

@roomsg mind checking out and reviewing PR #57 ? Hopefully it solves this problem for you.

@roomsg
Copy link
Author

roomsg commented Jul 14, 2015

Thx, will do a quick review of #57

@Moocar
Copy link
Owner

Moocar commented Sep 19, 2015

Solved in #57

@Moocar Moocar closed this as completed Sep 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Moocar @roomsg