feat: use ansible_facts in place of variables

Author: jackhodgkiss

molecule/org/verify.yml

@@ -10,7 +10,7 @@
     - runner_org: yes
     - github_api_url: "https://api.github.com"
     - access_token: "{{ lookup('env', 'PERSONAL_ACCESS_TOKEN') }}"
-    - runner_name: "{{ ansible_hostname }}"
+    - runner_name: "{{ ansible_facts.hostname }}"
 
   tasks:
     - name: Give the runners a minute

molecule/repo/verify.yml

@@ -10,7 +10,7 @@
     - github_account: monolithprojects-testorg
     - github_api_url: "https://api.github.com"
     - access_token: "{{ lookup('env', 'PERSONAL_ACCESS_TOKEN') }}"
-    - runner_name: "{{ ansible_hostname }}"
+    - runner_name: "{{ ansible_facts.hostname }}"
 
   tasks:
     - name: Give the runners some time

tasks/collect_info.yml

@@ -53,7 +53,7 @@
 
     - name: Set runner_system variable
       ansible.builtin.set_fact:
-        runner_system: "{{ 'osx' if ansible_system == 'Darwin' else 'linux' }}"
+        runner_system: "{{ 'osx' if ansible_facts.system == 'Darwin' else 'linux' }}"
 
     - name: Find the latest runner version (RUN ONCE)
       ansible.builtin.uri:
@@ -74,4 +74,4 @@
     - name: Get systemd service facts
       ansible.builtin.service_facts:
       register: service_facts
-      when: ansible_system == "Linux"
+      when: ansible_facts.system  == "Linux"

tasks/install_deps.yml

@@ -11,7 +11,7 @@
       - libicu57
     state: present
     update_cache: true
-  when: (ansible_distribution == "Debian" and ansible_distribution_major_version == "9")
+  when: (ansible_facts.distribution == "Debian" and ansible_facts.distribution_major_version == "9")
 
 - name: Install dependencies on Debian Buster
   ansible.builtin.package:
@@ -24,7 +24,7 @@
       - libicu63
     state: present
     update_cache: true
-  when: (ansible_distribution == "Debian" and ansible_distribution_major_version == "10")
+  when: (ansible_facts.distribution == "Debian" and ansible_facts.distribution_major_version == "10")
 
 - name: Install dependencies on Debian Bullseye
   ansible.builtin.package:
@@ -37,7 +37,7 @@
       - libicu67
     state: present
     update_cache: true
-  when: (ansible_distribution == "Debian" and ansible_distribution_major_version == "11")
+  when: (ansible_facts.distribution == "Debian" and ansible_facts.distribution_major_version == "11")
 
 - name: Install dependencies on Debian Bookworm
   ansible.builtin.package:
@@ -50,7 +50,7 @@
       - libicu72
     state: present
     update_cache: true
-  when: (ansible_distribution == "Debian" and ansible_distribution_major_version == "12")
+  when: (ansible_facts.distribution == "Debian" and ansible_facts.distribution_major_version == "12")
 
 - name: Install dependencies on Ubuntu Xenial systems
   ansible.builtin.package:
@@ -63,7 +63,7 @@
       - libicu55
     state: present
     update_cache: true
-  when: (ansible_distribution == "Ubuntu" and ansible_distribution_major_version == "16")
+  when: (ansible_facts.distribution == "Ubuntu" and ansible_facts.distribution_major_version == "16")
 
 - name: Install dependencies on Ubuntu Bionic systems
   ansible.builtin.package:
@@ -76,7 +76,7 @@
       - libicu60
     state: present
     update_cache: true
-  when: (ansible_distribution == "Ubuntu" and ansible_distribution_major_version == "18")
+  when: (ansible_facts.distribution == "Ubuntu" and ansible_facts.distribution_major_version == "18")
 
 - name: Install dependencies on Ubuntu Focal systems
   ansible.builtin.package:
@@ -89,7 +89,7 @@
       - libicu66
     state: present
     update_cache: true
-  when: (ansible_distribution == "Ubuntu" and ansible_distribution_major_version == "20")
+  when: (ansible_facts.distribution == "Ubuntu" and ansible_facts.distribution_major_version == "20")
 
 - name: Install dependencies on Ubuntu Jammy systems
   ansible.builtin.package:
@@ -101,7 +101,7 @@
       - libicu70
     state: present
     update_cache: true
-  when: (ansible_distribution == "Ubuntu" and ansible_distribution_major_version == "22")
+  when: (ansible_facts.distribution == "Ubuntu" and ansible_facts.distribution_major_version == "22")
 
 - name: Install dependencies on RHEL/CentOS/Fedora systems
   ansible.builtin.package:
@@ -113,7 +113,7 @@
       - libicu
     state: present
     update_cache: true
-  when: (ansible_distribution == "RedHat") or
-        (ansible_distribution == "CentOS") or
-        (ansible_distribution == "Fedora") or
-        (ansible_distribution == "Rocky")
+  when: (ansible_facts.distribution == "RedHat") or
+        (ansible_facts.distribution == "CentOS") or
+        (ansible_facts.distribution == "Fedora") or
+        (ansible_facts.distribution == "Rocky")

tasks/install_runner.yml

@@ -29,7 +29,7 @@
     remote_src: true
     mode: "0755"
   environment:
-    PATH: /usr/local/bin:/opt/homebrew/bin/:{{ ansible_env.HOME }}/bin:{{ ansible_env.PATH }}
+    PATH: /usr/local/bin:/opt/homebrew/bin/:{{ ansible_facts.user_dir }}/bin:{{ ansible_facts.env.PATH }}
   when: runner_version not in runner_installed.stdout or reinstall_runner
 
 - name: Configure custom env file if required
@@ -109,7 +109,7 @@
   args:
     chdir: "{{ runner_dir }}"
   changed_when: true
-  become: "{{ 'false' if ansible_system == 'Darwin' else 'true' }}"
+  become: "{{ 'false' if ansible_facts.system == 'Darwin' else 'true' }}"
   when: not runner_service_file_path.stat.exists
 
 - name: Read service name from file
@@ -125,7 +125,7 @@
   ignore_errors: "{{ ansible_check_mode }}"
   changed_when: true
   when: >
-    ansible_system != 'Darwin' and
+    ansible_facts.system != 'Darwin' and
     runner_state|lower == "started" and
     ansible_facts.services[(runner_service.content | b64decode) | trim ]['state'] != 'running'
 
@@ -137,7 +137,7 @@
   no_log: "{{ hide_sensitive_logs | bool }}"
   ignore_errors: "{{ ansible_check_mode }}"
   changed_when: true
-  when: ansible_system == 'Darwin' and runner_state|lower
+  when: ansible_facts.system == 'Darwin' and runner_state|lower
 
 - name: STOP and disable Github Actions Runner service
   ansible.builtin.command: "./svc.sh stop"
@@ -154,7 +154,7 @@
   args:
     chdir: "{{ runner_dir }}"
   changed_when: true
-  become: "{{ 'false' if ansible_system == 'Darwin' else 'true' }}"
+  become: "{{ 'false' if ansible_facts.system == 'Darwin' else 'true' }}"
   no_log: "{{ hide_sensitive_logs | bool }}"
   ignore_errors: "{{ ansible_check_mode }}"
   when: runner_version not in runner_installed.stdout and not runner_state|lower == "stopped"

tasks/uninstall_runner.yml

@@ -9,7 +9,7 @@
   args:
     chdir: "{{ runner_dir }}"
   changed_when: true
-  become: "{{ 'false' if ansible_system == 'Darwin' else 'true' }}"
+  become: "{{ 'false' if ansible_facts.system == 'Darwin' else 'true' }}"
   when: runner_service_file_path.stat.exists
 
 - name: Check GitHub Actions runner file

vars/main.yml

@@ -5,4 +5,4 @@ github_actions_architecture_map:
   x86_64: x64
   armv7l: arm
   aarch64: arm64
-github_actions_architecture: "{{ github_actions_architecture_map[ansible_architecture] }}"
+github_actions_architecture: "{{ github_actions_architecture_map[ansible_facts.architecture] }}"