Fixed a small bug and some minor changes

- Updated testing lib
- Added some docs in the tests

Signed-off-by: DeathsGun <deathsgun@protonmail.com>

Author: DeathsGun

build.gradle

@@ -42,11 +42,11 @@ dependencies {
     minecraft "com.mojang:minecraft:${project.minecraft_version}"
     mappings "net.fabricmc:yarn:${project.yarn_mappings}:v2"
     modImplementation "net.fabricmc:fabric-loader:${project.loader_version}"
-    
+
     modImplementation "net.fabricmc:fabric-language-kotlin:${project.fabric_kotlin_version}"
     modImplementation "com.terraformersmc:modmenu:${project.modmenu_version}"
 
-    testImplementation "org.jetbrains.kotlin:kotlin-test:1.5.21"
+    testImplementation 'org.jetbrains.kotlin:kotlin-test:1.5.31'
 }
 
 processResources {

src/main/kotlin/xyz/deathsgun/modmanager/update/UpdateManager.kt

@@ -120,7 +120,12 @@ class UpdateManager {
 
         val queryResult = provider.search(metadata.name, Sorting.RELEVANCE, 0, 10)
         if (queryResult is ModsResult.Error) {
-            logger.warn("Error while searching for fallback id for mod {}: ", metadata.id, queryResult.cause)
+            logger.warn(
+                "Error while searching for fallback id for mod {}: {}",
+                metadata.id,
+                queryResult.text.key,
+                queryResult.cause
+            )
             ModManager.modManager.setModState(metadata.id, metadata.id, ModState.INSTALLED)
             return
         }

src/main/kotlin/xyz/deathsgun/modmanager/update/VersionFinder.kt

@@ -54,11 +54,7 @@ object VersionFinder {
         var latestVer: SemanticVersion? = null
         val installedVer = VersionDeserializer.deserializeSemantic(installedVersion)
         for (version in versions) {
-            val parsedVersion = try {
-                VersionDeserializer.deserializeSemantic(version.version)
-            } catch (e: VersionParsingException) {
-                continue
-            }
+            val parsedVersion = VersionDeserializer.deserializeSemantic(version.version)
             if (latestVersion == null) {
                 latestVersion = version
                 latestVer = parsedVersion
@@ -69,7 +65,7 @@ object VersionFinder {
                 latestVer = parsedVersion
             }
         }
-        if (installedVersion == latestVersion?.version || installedVer >= latestVer) {
+        if (installedVersion == latestVersion?.version || (latestVer != null && installedVer >= latestVer)) {
             return null
         }
         return latestVersion

src/test/kotlin/xyz/deathsgun/modmanager/dummy/DummyModrinthProvider.kt

@@ -31,6 +31,10 @@ import java.io.InputStreamReader
 import java.time.Instant
 import java.time.ZoneOffset
 
+/**
+ * Dummy which provided the version data
+ * for [xyz.deathsgun.modmanager.update.VersionFinderTest]
+ */
 internal class DummyModrinthVersionProvider : IModUpdateProvider {
 
     private val json = Json {
@@ -41,6 +45,10 @@ internal class DummyModrinthVersionProvider : IModUpdateProvider {
         return "Modrinth"
     }
 
+    /**
+     * Reads the provided id from /version/id.json
+     * @param id the mod slug from Modrinth
+     */
     @OptIn(ExperimentalSerializationApi::class)
     override fun getVersionsForMod(id: String): VersionResult {
         return try {

src/test/kotlin/xyz/deathsgun/modmanager/update/VersionFinderTest.kt

@@ -17,7 +17,6 @@
 package xyz.deathsgun.modmanager.update
 
 import net.fabricmc.loader.api.VersionParsingException
-import org.apache.logging.log4j.LogManager
 import org.junit.jupiter.api.DynamicTest.dynamicTest
 import org.junit.jupiter.api.TestFactory
 import org.junit.jupiter.api.fail
@@ -30,11 +29,17 @@ import kotlin.test.assertNotNull
 import kotlin.test.assertNull
 import kotlin.test.assertTrue
 
+/**
+ * Tests the [VersionFinder] implementation
+ */
 internal class VersionFinderTest {
 
-    private val logger = LogManager.getLogger()
     private val provider: IModUpdateProvider = DummyModrinthVersionProvider()
 
+    /**
+     * Tests the fallback for versions which are not following
+     * the SemVer scheme. These mods are resolved by their release date.
+     */
     @TestFactory
     fun findUpdateByFallback() = listOf(
         Scenario(
@@ -76,21 +81,45 @@ internal class VersionFinderTest {
         }
     }
 
+    /**
+     * Tests some version scenarios in which the [VersionFinder]
+     * should definitely return null.
+     */
     @TestFactory
     fun findUpdateByVersionError() = listOf(
+        /**
+         * This scenario will fail because mc1.17.1-0.7.1
+         * can not be parsed by the parser as it starts with mc.
+         */
         Scenario(
             "lithium",
-            "mc1.17.1-0.7.4",
+            "none",
             "mc1.17.1-0.7.1",
             Config.UpdateChannel.STABLE,
             "1.17"
         ),
+        /**
+         * This scenario will fail because fabric-5.3.3-BETA+6027c282
+         * can not be parsed by the parser as it starts with fabric.
+         */
         Scenario(
             "terra",
-            "5.4.1-BETA+40e95073",
+            "none",
             "fabric-5.3.3-BETA+6027c282",
             Config.UpdateChannel.ALL,
             "1.17"
+        ),
+        /**
+         * No update for this scenario should be found.
+         * When an update should be found this would be an
+         * error as 2.0.13 is the latest
+         */
+        Scenario(
+            "modmenu",
+            "none",
+            "2.0.13",
+            Config.UpdateChannel.STABLE,
+            "1.17"
         )
     ).map { scenario ->
         dynamicTest("${scenario.mod} ${scenario.expectedVersion} ${scenario.channel}") {
@@ -112,6 +141,9 @@ internal class VersionFinderTest {
         }
     }
 
+    /**
+     * This tests all mods which are following the semantic version scheme.
+     */
     @TestFactory
     fun findUpdateByVersion() = listOf(
         Scenario(
@@ -121,13 +153,6 @@ internal class VersionFinderTest {
             Config.UpdateChannel.ALL,
             "1.17"
         ),
-        Scenario(
-            "terra",
-            "5.4.1-BETA+40e95073",
-            "5.3.3-BETA+6027c282", // actually fabric-5.3.3-BETA+6027c282
-            Config.UpdateChannel.ALL,
-            "1.17"
-        ),
         Scenario(
             "modmenu",
             "2.0.13",