fix(uiSelectCtrl): ensureHighlightVisible triggered with closed dropdown

Stefan Zollinger · asiacomeau · commit 183850910cf3 · 2018-01-04T09:56:14.000-08:00
This fix ensures that the dropdown actually is open before calling _ensureHighlightVisible. Fixes: angular-ui#2050
diff --git a/src/uiSelectController.js b/src/uiSelectController.js
@@ -153,7 +153,7 @@ uis.controller('uiSelectCtrl',
       } else {
         $timeout(function () {
           ctrl.focusSearchInput(initSearchValue);
-          if(!ctrl.tagging.isActivated && ctrl.items.length > 1) {
+          if(!ctrl.tagging.isActivated && ctrl.items.length > 1 && ctrl.open) {
             _ensureHighlightVisible();
           }
         });

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ uis.controller('uiSelectCtrl',`
`153`	`153`	`} else {`
`154`	`154`	`$timeout(function () {`
`155`	`155`	`ctrl.focusSearchInput(initSearchValue);`
`156`		`- if(!ctrl.tagging.isActivated && ctrl.items.length > 1) {`
	`156`	`+ if(!ctrl.tagging.isActivated && ctrl.items.length > 1 && ctrl.open) {`
`157`	`157`	`_ensureHighlightVisible();`
`158`	`158`	`}`
`159`	`159`	`});`