Skip to content

Commit 62eb19d

Browse files
committed
Merge branch 'master' into release
2 parents 1607d27 + 1483b77 commit 62eb19d

File tree

2 files changed

+20
-25
lines changed

2 files changed

+20
-25
lines changed

CMakeLists.txt

Lines changed: 3 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
cmake_minimum_required(VERSION 3.0.2)
1+
cmake_minimum_required(VERSION 3.16.3)
22

33
set(EXTERNAL_DIR "${CMAKE_SOURCE_DIR}/external_imported")
44

@@ -78,14 +78,7 @@ endif()
7878
message(STATUS "VCPKG TRIPLET: ${VCPKG_TARGET_TRIPLET}")
7979

8080
# Don't specify languages yet in case we need to bump the cmake version
81-
project(EternalTCP VERSION 6.2.8 LANGUAGES NONE)
82-
83-
if(WIN32)
84-
message(STATUS "Windows detected. Bumping up cmake version.")
85-
86-
# Hack to force a higher minimum version on windows
87-
cmake_minimum_required(VERSION 3.15.0)
88-
endif()
81+
project(EternalTCP VERSION 6.2.9 LANGUAGES NONE)
8982

9083
enable_language(C)
9184
enable_language(CXX)
@@ -186,14 +179,6 @@ if(USE_SENTRY)
186179
endif()
187180
endif()
188181

189-
set(CMAKE_MODULE_PATH "${EXTERNAL_DIR}/cotire/CMake"
190-
${CMAKE_MODULE_PATH})
191-
include(cotire)
192-
193-
if(POLICY CMP0058)
194-
cmake_policy(SET CMP0058 NEW) # Needed for cotire
195-
endif()
196-
197182
option(CODE_COVERAGE "Enable code coverage" OFF)
198183
option(FUZZING "Enable builds for fuzz testing" OFF)
199184
option(BUILD_TESTING "Build tests" ON)
@@ -326,14 +311,7 @@ ENDIF()
326311

327312
macro(DECORATE_TARGET TARGET_NAME)
328313
add_sanitizers(${TARGET_NAME})
329-
set_target_properties(${TARGET_NAME} PROPERTIES COTIRE_CXX_PREFIX_HEADER_INIT
330-
"src/base/Headers.hpp")
331-
332-
if(CMAKE_CROSSCOMPILING)
333-
# Doesn't work when cross-compiling
334-
else()
335-
cotire(${TARGET_NAME})
336-
endif()
314+
target_precompile_headers(${TARGET_NAME} PUBLIC "src/base/Headers.hpp")
337315
endmacro()
338316

339317
macro(DECORATE_FUZZER TARGET_NAME)

docs/creating_release.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# Instructions to creating a new ET Release
2+
3+
1. Increment the project(...) version in CMakeLists.txt and push to master.
4+
2. Switch to the release branch
5+
3. Pull in the lastest changes: `git merge master`
6+
4. Run `git submodule update --recursive --init` to ensure that the submodules are updated to the latest master/release commit.
7+
5. Run `import_submodules.sh` to create an in-repo copy of the submodules
8+
6. `git add external_imported` and commit/push any changes
9+
7. Create a github release using the latest commit and tag it with `et-vA.B.C` where A/B/C is the major/minor/patch version.
10+
8. Switch to the deployment branch
11+
9. Edit the `deployment/debian_SOURCE/changelog` file and add a entry for the new release.
12+
10. Copy id_rsa / id_rsa.pub / .gnupg to the deploymen directory. The rsa key needs to have write access to the debian-et github repo and the gnupg key needs to have write access to launchpad
13+
11. Build and run a docker image interactively from ubuntu.Dockerfile
14+
12. inside the docker image, run deploy_ubuntu_ppa.sh
15+
13. Exit the docker image and create a vagrant VM for debian
16+
14. inside the vagrant vm, run build_all_deb.sh
17+
15. Follow the instructions at the end of the build_all_deb command to push the new debian artifacts. Do not push the dbgsym (debug symbols) because github cannot handle files that large

0 commit comments

Comments
 (0)