Remove overloading GradleUtilsExtension#unpack methods

These methods cause a GroovyRuntimeException as the runtime invoker
cannot choose between some of the overloading methods. This bug is rare
and only happens in composite builds, but that unfortunately affects Git
Version.

This is unfortunately a binary breaking change but does not affect
buildscripts. Plugins that shadow GradleUtils Shared are unaffected, and
there shouldn't be any plugins that are compiled to use GradleUtils at
runtime.

Author: Jonathing

gradleutils-shared/src/main/java/net/minecraftforge/gradleutils/shared/SharedUtil.java

@@ -471,70 +471,6 @@ public static String pathify(Dependency dependency) {
 
     //region Deferred Objects
 
-    /// Unpacks a deferred value.
-    ///
-    /// @param value The value to unpack
-    /// @param <T>   The type of value held by the provider
-    /// @return The unpacked value
-    /// @see #unpack(Object)
-    public static <T> T unpack(Provider<T> value) {
-        return value.get();
-    }
-
-    /// Unpacks a deferred value.
-    ///
-    /// @param value The value to unpack
-    /// @param <T>   The type of value held by the provider
-    /// @return The unpacked value
-    /// @see #unpack(Object)
-    public static <T> T unpack(ProviderConvertible<T> value) {
-        return value.asProvider().get();
-    }
-
-    /// Unpacks a deferred value.
-    ///
-    /// @param value The value to unpack
-    /// @param <T>   The type of value held by the provider
-    /// @return The unpacked value
-    /// @see #unpack(Object)
-    public static <T> T unpack(Closure<T> value) {
-        return Closures.invoke(value);
-    }
-
-    /// Unpacks a deferred value.
-    ///
-    /// @param value The value to unpack
-    /// @param <T>   The type of value held by the provider
-    /// @return The unpacked value
-    /// @see #unpack(Object)
-    public static <T> T unpack(Callable<T> value) {
-        try {
-            return value.call();
-        } catch (Exception e) {
-            throw new RuntimeException(e);
-        }
-    }
-
-    /// Unpacks a deferred value.
-    ///
-    /// @param value The value to unpack
-    /// @param <T>   The type of value held by the provider
-    /// @return The unpacked value
-    /// @see #unpack(Object)
-    public static <T> T unpack(Function0<T> value) {
-        return value.invoke();
-    }
-
-    /// Unpacks a deferred value.
-    ///
-    /// @param value The value to unpack
-    /// @param <T>   The type of value held by the provider
-    /// @return The unpacked value
-    /// @see #unpack(Object)
-    public static <T> T unpack(Supplier<T> value) {
-        return value.get();
-    }
-
     /// Unpacks a deferred value.
     ///
     /// Since buildscripts are dynamically compiled, this allows buildscript authors to use this method with version
@@ -547,17 +483,21 @@ public static <T> T unpack(Supplier<T> value) {
     @SuppressWarnings("unchecked")
     public static <T> T unpack(Object value) {
         if (value instanceof ProviderConvertible<?> deferred) {
-            return (T) unpack(deferred);
+            return (T) deferred.asProvider().get();
         } else if (value instanceof Provider<?> deferred) {
-            return (T) unpack(deferred);
+            return (T) deferred.get();
         } else if (value instanceof Closure<?> deferred) {
-            return (T) unpack(deferred);
+            return Closures.invoke(deferred);
         } else if (value instanceof Callable<?> deferred) {
-            return (T) unpack(deferred);
+            try {
+                return (T) deferred.call();
+            } catch (Exception e) {
+                throw new RuntimeException(e);
+            }
         } else if (value instanceof Function0<?> deferred) {
-            return (T) unpack(deferred);
+            return (T) deferred.invoke();
         } else if (value instanceof Supplier<?> deferred) {
-            return (T) unpack(deferred);
+            return (T) deferred.get();
         } else {
             return (T) value;
         }

src/main/groovy/net/minecraftforge/gradleutils/GradleUtilsExtension.java

@@ -275,66 +275,6 @@ default Action<MavenArtifactRepository> getPublishingForgeMaven(Provider<?> defa
 
     /* MISCELLANEOUS */
 
-    /// Unpacks a deferred value.
-    ///
-    /// @param value The value to unpack
-    /// @param <T>   The type of value held by the provider
-    /// @return The unpacked value
-    /// @see #unpack(Object)
-    default <T> T unpack(Provider<T> value) {
-        return Util.unpack(value);
-    }
-
-    /// Unpacks a deferred value.
-    ///
-    /// @param value The value to unpack
-    /// @param <T>   The type of value held by the provider
-    /// @return The unpacked value
-    /// @see #unpack(Object)
-    default <T> T unpack(ProviderConvertible<T> value) {
-        return Util.unpack(value);
-    }
-
-    /// Unpacks a deferred value.
-    ///
-    /// @param value The value to unpack
-    /// @param <T>   The type of value held by the provider
-    /// @return The unpacked value
-    /// @see #unpack(Object)
-    default <T> T unpack(Closure<T> value) {
-        return Util.unpack(value);
-    }
-
-    /// Unpacks a deferred value.
-    ///
-    /// @param value The value to unpack
-    /// @param <T>   The type of value held by the provider
-    /// @return The unpacked value
-    /// @see #unpack(Object)
-    default <T> T unpack(Callable<T> value) {
-        return Util.unpack(value);
-    }
-
-    /// Unpacks a deferred value.
-    ///
-    /// @param value The value to unpack
-    /// @param <T>   The type of value held by the provider
-    /// @return The unpacked value
-    /// @see #unpack(Object)
-    default <T> T unpack(Function0<T> value) {
-        return Util.unpack(value);
-    }
-
-    /// Unpacks a deferred value.
-    ///
-    /// @param value The value to unpack
-    /// @param <T>   The type of value held by the provider
-    /// @return The unpacked value
-    /// @see #unpack(Object)
-    default <T> T unpack(Supplier<T> value) {
-        return Util.unpack(value);
-    }
-
     /// Unpacks a deferred value.
     ///
     /// Since buildscripts are dynamically compiled, this allows buildscript authors to use this method with version