Skip to content

Commit 64dff97

Browse files
committed
Disable configuration cache until Gradle 9.0
Gradle's configuration cache comes with too many bugs to be worth the trouble. I will continue to make GradleUtils (along with our other plugins such as Licenser, ForgeGradle 7, etc.) compatible with it.
1 parent ba99d5f commit 64dff97

File tree

3 files changed

+17
-14
lines changed

3 files changed

+17
-14
lines changed

build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ changelog {
5454
}
5555

5656
gradlePlugin {
57-
website = gitversion.url
58-
vcsUrl = "${gitversion.url}.git"
57+
website.set gitversion.url
58+
vcsUrl.set gitversion.url + '.git'
5959
plugins {
6060
gradleutils {
6161
id = 'net.minecraftforge.gradleutils'

gradle.properties

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
org.gradle.caching=true
22
org.gradle.parallel=true
33
org.gradle.configureondemand=true
4-
org.gradle.configuration-cache=true
5-
org.gradle.configuration-cache.parallel=true
6-
org.gradle.configuration-cache.problems=warn
4+
5+
# TODO [GradleUtils][Gradle9] Re-enable config cache in Gradle 9
6+
# Configuration Cache comes with too many bugs to be worth the trouble.
7+
# Do continue to make our Gradle plugins (GU, FG7, etc.) support it though.
8+
org.gradle.configuration-cache=false
9+
org.gradle.configuration-cache.parallel=false

src/main/groovy/net/minecraftforge/gradleutils/changelog/ChangelogExtension.groovy

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,30 +22,30 @@ class ChangelogExtension {
2222

2323
@PackageScope final Project project
2424

25+
/** @deprecated The Git root is automatically discovered by Git Version on Changelog generation. */
26+
@Deprecated(forRemoval = true)
27+
@ApiStatus.ScheduledForRemoval(inVersion = '3.0')
28+
@Nullable Directory gitRoot
29+
2530
boolean publishAll = true
2631
@PackageScope boolean isGenerating
2732
private @Lazy TaskProvider<GenerateChangelog> task = {
28-
ChangelogUtils.setupChangelogTask(this.project) { task ->
29-
this.isGenerating = true
33+
this.isGenerating = true
3034

31-
this.project.afterEvaluate {
35+
ChangelogUtils.setupChangelogTask(this.project) { task ->
36+
this.project.afterEvaluate { project ->
3237
if (this.gitRoot) {
3338
task.configure {
3439
it.gitDirectory.set gitRoot
3540
}
3641
}
3742

3843
if (this.publishAll)
39-
ChangelogUtils.setupChangelogGenerationOnAllPublishTasks it
44+
ChangelogUtils.setupChangelogGenerationOnAllPublishTasks project
4045
}
4146
}
4247
}()
4348

44-
/** @deprecated The Git root is automatically discovered by Git Version on Changelog generation. */
45-
@Deprecated(forRemoval = true)
46-
@ApiStatus.ScheduledForRemoval(inVersion = '3.0')
47-
@Nullable Directory gitRoot
48-
4949
/** @deprecated This constructor will be made package-private in GradleUtils 3.0 */
5050
@Inject
5151
@Deprecated(forRemoval = true)

0 commit comments

Comments
 (0)