Chunkcacher can change village loot

[DuncanRuns]

Version Information

1.4.2+1.16.1

Expected Behavior

Seed looks like vanilla

Actual Behavior

Seed doesn't look like vanilla

Reproduction Steps

Use the mod on the seed

System Information

N/A (Irrelevant)

Other Information

Original Discord Post

I found this bug - seems to impact verifiability a lot so I thought I would make a ticket
on this specific seed (-4440574568375984014, 1.16.1) chunkcacher changes loot of this blacksmith

(Video)

On the first reset its the expected loot. But on the second reset and after the loot is consistently wrong.
I removed Chunkcacher and this doesn't happen anymore.
I tried changing java versions/builds and it still happens
There is another blacksmith on this seed, and that loot does not change.
I never saw this bug on any other seed
This also happens on 1.16.5
So i think this is a bug with every version of chunkcacher

[tildejustin]

could we please ban chunkcacher for versions w/ seedqueue? unless you have time to port char's fix (assuming that fixes this), I very much do not

[DuncanRuns]

I have some time, what/where is char's fix?

[tildejustin]

merged into 1.16.x and 1.17.x. I may have my 1.18.1 port on my repo but it was so slow I pretty much gave up after that

[DuncanRuns]

I'll look into it