Skip to content
This repository was archived by the owner on Jan 21, 2023. It is now read-only.

Commit 2e4c536

Browse files
committed
refactor: PR feedback
1 parent ecb3246 commit 2e4c536

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

src/structurizr/view/view_set.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -371,10 +371,7 @@ def get_view(self, key: str) -> Optional[AbstractView]:
371371

372372
def __getitem__(self, key: str) -> AbstractView:
373373
"""Return the view with the given key or raise a KeyError."""
374-
result = self._views.get(key)
375-
if not result:
376-
raise KeyError(f"No view with key '{key}' in ViewSet")
377-
return result
374+
return self._views[key]
378375

379376
def copy_layout_information_from(self, source: "ViewSet") -> None:
380377
"""Copy all the layout information from a source ViewSet."""

tests/unit/view/test_view_set.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ def test_getting_view_by_key(empty_viewset):
125125
assert viewset.get_view("container1") is container_view
126126
assert viewset.get_view("bogus") is None
127127
assert viewset["container1"] is container_view
128-
with pytest.raises(KeyError, match="No view with key"):
128+
with pytest.raises(KeyError):
129129
viewset["bogus"]
130130

131131

0 commit comments

Comments
 (0)