Skip to content
This repository was archived by the owner on Jan 21, 2023. It is now read-only.

Commit 22680f5

Browse files
yt-msMidnighter
authored andcommitted
refactor: Model._add_relationship always returns True so redundant
1 parent 482cea5 commit 22680f5

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

src/structurizr/model/model.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -310,11 +310,8 @@ def add_relationship(
310310
"""
311311
if relationship is None:
312312
relationship = Relationship(**kwargs)
313-
# Check
314-
if self._add_relationship(relationship, create_implied_relationships):
315-
return relationship
316-
else:
317-
return
313+
self._add_relationship(relationship, create_implied_relationships)
314+
return relationship
318315

319316
def get_element(self, id: str) -> Optional[Element]:
320317
"""
@@ -373,9 +370,9 @@ def _add_element(self, element: Element) -> None:
373370

374371
def _add_relationship(
375372
self, relationship: Relationship, create_implied_relationships: bool
376-
) -> bool:
373+
):
377374
if relationship in self.get_relationships():
378-
return True
375+
return
379376
if not relationship.id:
380377
relationship.id = self._id_generator.generate_id()
381378
elif relationship.id in self._elements_by_id:
@@ -395,7 +392,6 @@ def _add_relationship(
395392

396393
if create_implied_relationships:
397394
self.implied_relationship_strategy(relationship)
398-
return True
399395

400396
def _add_relationship_to_internal_structures(self, relationship: Relationship):
401397
self._relationships_by_id[relationship.id] = relationship

0 commit comments

Comments
 (0)