Skip to content

cons.saver setgid paranoia: Fail if !HAVE_STRUCT_STAT_ST_RDEV #4847

@egmontkob

Description

@egmontkob

Is there an existing issue for this?

  • I have searched the existing issues

Midnight Commander version and build configuration

4.8.33, git

Operating system

Linux

Is this issue reproducible using the latest version of Midnight Commander?

  • I confirm the issue is still reproducible with the latest version of Midnight Commander

How to reproduce

In setgid cons.saver, if ! HAVE_STRUCT_STAT_ST_RDEV then we blindly assume minor number 1 with a "FIXME" in the source.

This code is Linux-specific, and Linux does have st_rdev.

In the unlikely case that it's not available, let's fail (either buildtime or runtime) instead of making faulty assumptions.

Expected behavior

.

Actual behavior

.

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: ttyInteraction with the terminal, screen librariesprio: mediumHas the potential to affect progress

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions