Use constants for copyright and package name to avoid duplication

Signed-off-by: Yury V. Zaytsev <yury@shurup.com>

Author: zyv

lib/global.c

@@ -114,6 +114,8 @@ mc_global_t mc_global =
 
 };
 
+const char PACKAGE_COPYRIGHT[] = N_ ("Copyright (C) 1996-2025 the Free Software Foundation");
+
 #undef SUBSHELL_USE
 
 /*** file scope macro definitions ****************************************************************/

lib/global.h

@@ -224,6 +224,7 @@ typedef struct
 /*** global variables defined in .c file *********************************************************/
 
 extern mc_global_t mc_global;
+extern const char PACKAGE_COPYRIGHT[];
 
 /*** declarations of public functions ************************************************************/
 

maint/update-years.sh

@@ -21,8 +21,8 @@ for i in $SOURCES; do
 done
 
 # special case
-${SED-sed} -e "/$LINE/s/-[0-9]\{4\} the/-$YEAR the/" src/editor/editwidget.c > src/editor/editwidget.c.tmp && \
-  mv -f src/editor/editwidget.c.tmp src/editor/editwidget.c
+${SED-sed} -e "/$LINE/s/-[0-9]\{4\} the/-$YEAR the/" lib/global.c > lib/global.c.tmp && \
+  mv -f lib/global.c.tmp lib/global.c
 
 # restore permissions
 chmod 755 tests/src/vfs/extfs/helpers-list/test_all

src/args.c

@@ -459,10 +459,10 @@ mc_args_add_extended_info_to_help (void)
 {
     mc_args__loc__footer_string =
         g_strdup_printf (_ ("\n"
-                            "Please send any bug reports (including the output of 'mc -V')\n"
+                            "Please send any bug reports (including the output of '%s -V')\n"
                             "as tickets at %s\n"),
-                         PACKAGE_BUGREPORT);
-    mc_args__loc__header_string = g_strdup_printf (PACKAGE_NAME " %s\n", mc_global.mc_version);
+                         PACKAGE, PACKAGE_BUGREPORT);
+    mc_args__loc__header_string = g_strdup_printf ("%s %s\n", PACKAGE_NAME, mc_global.mc_version);
 
     g_option_context_set_description (context, mc_args__loc__footer_string);
     g_option_context_set_summary (context, mc_args__loc__header_string);

src/diffviewer/ydiff.c

@@ -2966,15 +2966,17 @@ dview_ok_to_exit (WDiff *dview)
 {
     gboolean res = TRUE;
     int act;
+    char *text;
 
     if (!dview->merged[DIFF_LEFT] && !dview->merged[DIFF_RIGHT])
         return res;
 
-    act = query_dialog (_ ("Quit"),
-                        !mc_global.midnight_shutdown
-                            ? _ ("File(s) was modified. Save with exit?")
-                            : _ ("Midnight Commander is being shut down.\nSave modified file(s)?"),
-                        D_NORMAL, 2, _ ("&Yes"), _ ("&No"));
+    text = g_strdup_printf (!mc_global.midnight_shutdown
+                                ? _ ("File(s) was modified. Save with exit?")
+                                : _ ("%s is being shut down.\nSave modified file(s)?"),
+                            PACKAGE_NAME);
+    act = query_dialog (_ ("Quit"), text, D_NORMAL, 2, _ ("&Yes"), _ ("&No"));
+    g_free (text);
 
     // Esc is No
     if (mc_global.midnight_shutdown || (act == -1))

src/editor/editcmd.c

@@ -1474,7 +1474,7 @@ edit_ok_to_exit (WEdit *edit)
     }
     else
     {
-        msg = g_strdup_printf (_ ("Midnight Commander is being shut down.\nSave modified file %s?"),
+        msg = g_strdup_printf (_ ("%s is being shut down.\nSave modified file %s?"), PACKAGE_NAME,
                                fname);
         act = edit_query_dialog2 (_ ("Quit"), msg, _ ("&Yes"), _ ("&No"));
 

src/editor/editwidget.c

@@ -137,19 +137,20 @@ edit_dlg_deinit (void)
 static void
 edit_about (void)
 {
-    char *ver;
+    char *ver, *desc;
 
     ver = g_strdup_printf ("MCEdit %s", mc_global.mc_version);
+    desc = g_strdup_printf (N_ ("A user friendly text editor\n"
+                                "written for the %s."),
+                            PACKAGE_NAME);
 
     {
         quick_widget_t quick_widgets[] = {
             QUICK_LABEL (ver, NULL),
             QUICK_SEPARATOR (TRUE),
-            QUICK_LABEL (N_ ("A user friendly text editor\n"
-                             "written for the Midnight Commander."),
-                         NULL),
+            QUICK_LABEL (desc, NULL),
             QUICK_SEPARATOR (FALSE),
-            QUICK_LABEL (N_ ("Copyright (C) 1996-2025 the Free Software Foundation"), NULL),
+            QUICK_LABEL (PACKAGE_COPYRIGHT, NULL),
             QUICK_START_BUTTONS (TRUE, TRUE),
             QUICK_BUTTON (N_ ("&OK"), B_ENTER, NULL, NULL),
             QUICK_END,
@@ -174,6 +175,7 @@ edit_about (void)
     }
 
     g_free (ver);
+    g_free (desc);
 }
 
 /* --------------------------------------------------------------------------------------------- */

src/execute.c

@@ -505,7 +505,7 @@ toggle_subshell (void)
     {
         if (output_starts_shell)
         {
-            fputs (_ ("Type 'exit' to return to the Midnight Commander"), stderr);
+            fprintf (stderr, _ ("Type 'exit' to return to the %s"), PACKAGE_NAME);
             fputs ("\n\r\n\r", stderr);
 
             my_system (EXECUTE_INTERNAL, mc_global.shell->path, NULL);

src/filemanager/boxes.c

@@ -493,7 +493,7 @@ about_box (void)
     char *label_cp_display;
     char *label_cp_source;
 
-    char *version = g_strdup_printf ("Midnight Commander %s", mc_global.mc_version);
+    char *version = g_strdup_printf ("%s %s", PACKAGE_NAME, mc_global.mc_version);
 
     const char *name_cp_display =
         ((codepage_desc *) g_ptr_array_index (codepages, mc_global.display_codepage))->name;
@@ -512,7 +512,7 @@ about_box (void)
         QUICK_SEPARATOR (TRUE),
         QUICK_LABEL (N_ ("Classic terminal file manager inspired by Norton Commander."), NULL),
         QUICK_SEPARATOR (FALSE),
-        QUICK_LABEL (N_ ("Copyright (C) 1996-2025 the Free Software Foundation"), NULL),
+        QUICK_LABEL (PACKAGE_COPYRIGHT, NULL),
         QUICK_SEPARATOR (TRUE),
         QUICK_LABEL (label_cp_display, NULL),
         QUICK_LABEL (label_cp_source, NULL),

src/filemanager/ext.c

@@ -772,9 +772,9 @@ check_old_extension_file (void)
     extension_old_file = mc_config_get_full_path (MC_EXT_OLD_FILE);
     if (exist_file (extension_old_file))
         message (D_ERROR, _ ("Warning"),
-                 _ ("You have an outdated %s file.\nMidnight Commander now uses %s file.\n"
+                 _ ("You have an outdated %s file.\n%s now uses %s file.\n"
                     "Please copy your modifications of the old file to the new one."),
-                 extension_old_file, MC_EXT_FILE);
+                 extension_old_file, PACKAGE_NAME, MC_EXT_FILE);
     g_free (extension_old_file);
 }
 
@@ -825,8 +825,8 @@ load_extension_file (void)
             message (D_ERROR, MSG_ERROR,
                      _ ("The format of the\n%s%s\nfile has changed with version 4.0.\n"
                         "It seems that the installation has failed.\nPlease fetch a fresh copy "
-                        "from the Midnight Commander package."),
-                     mc_global.sysconfig_dir, MC_EXT_FILE);
+                        "from the %s package."),
+                     mc_global.sysconfig_dir, MC_EXT_FILE, PACKAGE_NAME);
             return FALSE;
         }