(check_file_access): return FALSE immediately in case of error message

aborodin · aborodin · commit 737de0827f59 · 2025-05-27T22:24:52.000+03:00
...to get rid of double rising of error message.

Signed-off-by: Andrew Borodin &lt;aborodin@vmail.ru&gt;
diff --git a/src/editor/edit.c b/src/editor/edit.c
@@ -308,7 +308,7 @@ check_file_access (WEdit *edit, const vfs_path_t *filename_vpath, struct stat *s
         if (file < 0)
         {
             file_error_message (_ ("Cannot open\n%s"), vfs_path_as_str (filename_vpath));
-            goto cleanup;
+            return FALSE;
         }
 
         // New file, delete it if it's not modified or saved
@@ -319,7 +319,7 @@ check_file_access (WEdit *edit, const vfs_path_t *filename_vpath, struct stat *s
     if (mc_fstat (file, st) < 0)
     {
         file_error_message (_ ("Cannot stat\n%s"), vfs_path_as_str (filename_vpath));
-        goto cleanup;
+        return FALSE;
     }
 
     // We want to open regular files only

Original file line number	Diff line number	Diff line change
`@@ -308,7 +308,7 @@ check_file_access (WEdit edit, const vfs_path_t filename_vpath, struct stat *s`
`308`	`308`	`if (file < 0)`
`309`	`309`	`{`
`310`	`310`	`file_error_message (_ ("Cannot open\n%s"), vfs_path_as_str (filename_vpath));`
`311`		`- goto cleanup;`
	`311`	`+ return FALSE;`
`312`	`312`	`}`
`313`	`313`
`314`	`314`	`// New file, delete it if it's not modified or saved`
`@@ -319,7 +319,7 @@ check_file_access (WEdit edit, const vfs_path_t filename_vpath, struct stat *s`
`319`	`319`	`if (mc_fstat (file, st) < 0)`
`320`	`320`	`{`
`321`	`321`	`file_error_message (_ ("Cannot stat\n%s"), vfs_path_as_str (filename_vpath));`
`322`		`- goto cleanup;`
	`322`	`+ return FALSE;`
`323`	`323`	`}`
`324`	`324`
`325`	`325`	`// We want to open regular files only`