Skip to content

Commit 8a0782f

Browse files
authored
Clessig/develop/fix loss 678 (ecmwf#679)
* Changed logging level for some messages. * Fixing bug with incorrect counting
1 parent 089de3b commit 8a0782f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/weathergen/train/loss_calculator.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -326,8 +326,8 @@ def compute_loss(
326326
loss_fstep = loss_fstep + (loss_fct_weight * loss_lfct * strm_loss_weight)
327327
ctr_fsteps += 1 if loss_lfct > 0.0 else 0
328328

329-
loss = loss + loss_fstep / ctr_fsteps if ctr_fsteps > 0 else loss
330-
ctr_streams += 1 if loss_fstep > 0 else 0
329+
loss = loss + (loss_fstep / (ctr_fsteps if ctr_fsteps > 0 else 1.0))
330+
ctr_streams += 1 if ctr_fsteps > 0 else 0
331331

332332
# normalize by forecast step
333333
losses_all[strm.name] /= ctr_fsteps if ctr_fsteps > 0 else 1.0

0 commit comments

Comments
 (0)