Skip to content

feat: solana opt-in changes cp-7.46.0 #14888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025
Merged

feat: solana opt-in changes cp-7.46.0 #14888

merged 4 commits into from
Apr 28, 2025

Conversation

aganglada
Copy link
Contributor

Description

  • Added Learn more link
  • Changed call to action when the use has a solana account

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Simulator Screenshot - iPhone 16 Pro - 2025-04-25 at 13 46 17

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@aganglada aganglada self-assigned this Apr 25, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@aganglada aganglada added Run Smoke E2E Requires smoke E2E testing QA Passed QA testing has been completed and passed labels Apr 25, 2025
Copy link
Contributor

github-actions bot commented Apr 25, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 273161e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/07f46c7f-5627-49f5-9a39-247877ab1ad4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.83%. Comparing base (944fce2) to head (dfbb2e8).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
...olanaNewFeatureContent/SolanaNewFeatureContent.tsx 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14888      +/-   ##
==========================================
+ Coverage   67.71%   67.83%   +0.11%     
==========================================
  Files        2329     2342      +13     
  Lines       50144    50390     +246     
  Branches     7373     7431      +58     
==========================================
+ Hits        33954    34180     +226     
- Misses      14054    14056       +2     
- Partials     2136     2154      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zone-live zone-live added this pull request to the merge queue Apr 28, 2025
Merged via the queue into main with commit b725826 Apr 28, 2025
40 checks passed
@zone-live zone-live deleted the feat/opt-in-changes branch April 28, 2025 09:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label Apr 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
QA Passed QA testing has been completed and passed release-7.47.0 Issue or pull request that will be included in release 7.47.0 Run Smoke E2E Requires smoke E2E testing team-solana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants