-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Disable Blockies icons by default (for performance improvements) #14878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
609f99e
to
ce5bd0c
Compare
528ff7b
to
2e16bd7
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing optimizations lately
@vinnyhoward did you test yourself? I have been getting mixed results and so has @gantunesr ? |
Thank you @owencraston ! Can you confirm that the default setting only affects new users? In spite of the performance improvement (totally understand and agree this is a critical focus area), I want to make sure we don't change the avatar for existing users in one release, and then again two releases later. We're introducing a new avatar altogether. Any performance gain for new users is a no-brainer, but for existing users I want to make sure we don't change their avatars twice. |
@hesterbruikman two things...
|
Understood, ty @owencraston ! |
Description
We noticed during our testing that Blockies account icons take much longer to calculate than equivalent Jazzicons. This change is quite simple, it simply set the default icon type to be jazzicon vs blockies. This is done by setting the deafult value of
useBlockieIcon
to false. The result is...~49% decrease in the time to render of the account list
((3.96-2.06)/3.86)*100 = 49.2227979275
This was tested on my Google Pixel 6 in debug mode. I had 18 accounts including one Solana account with balances.
Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/919
Manual testing steps
METAMASK_BUILD_TYPE
to bebeta
in your.js.env
Screenshots/Recordings
Before
After
Confirmed that changing your icons back to blockies works as expected.
screen-20250425-134435.mp4
Pre-merge author checklist
Pre-merge reviewer checklist